Commit a1b42bef authored by Punit Vara's avatar Punit Vara Committed by Greg Kroah-Hartman

Staging: rtl8712: Use ether_addr_equal() over memcmp()

This patch is to the rtl871x_ioctl_linux.c file that fixes up following
warning reported by checkpatch.pl :

-Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp()

bssid and pnetwork->network.MacAddress both are 6 byte
array which aligned with u16
Signed-off-by: default avatarPunit Vara <punitvara@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e904cc8f
...@@ -1981,7 +1981,7 @@ static int r871x_get_ap_info(struct net_device *dev, ...@@ -1981,7 +1981,7 @@ static int r871x_get_ap_info(struct net_device *dev,
return -EINVAL; return -EINVAL;
} }
netdev_info(dev, "r8712u: BSSID:%pM\n", bssid); netdev_info(dev, "r8712u: BSSID:%pM\n", bssid);
if (!memcmp(bssid, pnetwork->network.MacAddress, ETH_ALEN)) { if (ether_addr_equal(bssid, pnetwork->network.MacAddress)) {
/* BSSID match, then check if supporting wpa/wpa2 */ /* BSSID match, then check if supporting wpa/wpa2 */
pbuf = r8712_get_wpa_ie(&pnetwork->network.IEs[12], pbuf = r8712_get_wpa_ie(&pnetwork->network.IEs[12],
&wpa_ielen, pnetwork->network.IELength-12); &wpa_ielen, pnetwork->network.IELength-12);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment