Commit a1c088e0 authored by Oliver Neukum's avatar Oliver Neukum Committed by David S. Miller

usbnet: handle PM failure gracefully

If a device fails to do remote wakeup, this is no reason
to abort an open totally. This patch just continues without
runtime PM.
Signed-off-by: default avatarOliver Neukum <oneukum@suse.de>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4945106d
...@@ -719,7 +719,8 @@ int usbnet_stop (struct net_device *net) ...@@ -719,7 +719,8 @@ int usbnet_stop (struct net_device *net)
dev->flags = 0; dev->flags = 0;
del_timer_sync (&dev->delay); del_timer_sync (&dev->delay);
tasklet_kill (&dev->bh); tasklet_kill (&dev->bh);
if (info->manage_power) if (info->manage_power &&
!test_and_clear_bit(EVENT_NO_RUNTIME_PM, &dev->flags))
info->manage_power(dev, 0); info->manage_power(dev, 0);
else else
usb_autopm_put_interface(dev->intf); usb_autopm_put_interface(dev->intf);
...@@ -794,14 +795,14 @@ int usbnet_open (struct net_device *net) ...@@ -794,14 +795,14 @@ int usbnet_open (struct net_device *net)
tasklet_schedule (&dev->bh); tasklet_schedule (&dev->bh);
if (info->manage_power) { if (info->manage_power) {
retval = info->manage_power(dev, 1); retval = info->manage_power(dev, 1);
if (retval < 0) if (retval < 0) {
goto done_manage_power_error; retval = 0;
usb_autopm_put_interface(dev->intf); set_bit(EVENT_NO_RUNTIME_PM, &dev->flags);
} else {
usb_autopm_put_interface(dev->intf);
}
} }
return retval; return retval;
done_manage_power_error:
clear_bit(EVENT_DEV_OPEN, &dev->flags);
done: done:
usb_autopm_put_interface(dev->intf); usb_autopm_put_interface(dev->intf);
done_nopm: done_nopm:
......
...@@ -69,6 +69,7 @@ struct usbnet { ...@@ -69,6 +69,7 @@ struct usbnet {
# define EVENT_DEV_ASLEEP 6 # define EVENT_DEV_ASLEEP 6
# define EVENT_DEV_OPEN 7 # define EVENT_DEV_OPEN 7
# define EVENT_DEVICE_REPORT_IDLE 8 # define EVENT_DEVICE_REPORT_IDLE 8
# define EVENT_NO_RUNTIME_PM 9
}; };
static inline struct usb_driver *driver_of(struct usb_interface *intf) static inline struct usb_driver *driver_of(struct usb_interface *intf)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment