Commit a73f8844 authored by Jonathan Corbet's avatar Jonathan Corbet Committed by Linus Torvalds

lglock: make lg_lock_global() actually lock globally

lg_lock_global() currently only acquires spinlocks for online CPUs, but
it's meant to lock all possible CPUs.  Lglock-protected resources may be
associated with removed CPUs - and, indeed, that could happen with the
per-superblock open files lists.

At Nick's suggestion, change for_each_online_cpu() to
for_each_possible_cpu() to protect accesses to those resources.

Cc: Al Viro <viro@ZenIV.linux.org.uk>
Acked-by: default avatarNick Piggin <npiggin@kernel.dk>
Signed-off-by: default avatarJonathan Corbet <corbet@lwn.net>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 39aa3cb3
...@@ -150,7 +150,7 @@ ...@@ -150,7 +150,7 @@
int i; \ int i; \
preempt_disable(); \ preempt_disable(); \
rwlock_acquire(&name##_lock_dep_map, 0, 0, _RET_IP_); \ rwlock_acquire(&name##_lock_dep_map, 0, 0, _RET_IP_); \
for_each_online_cpu(i) { \ for_each_possible_cpu(i) { \
arch_spinlock_t *lock; \ arch_spinlock_t *lock; \
lock = &per_cpu(name##_lock, i); \ lock = &per_cpu(name##_lock, i); \
arch_spin_lock(lock); \ arch_spin_lock(lock); \
...@@ -161,7 +161,7 @@ ...@@ -161,7 +161,7 @@
void name##_global_unlock(void) { \ void name##_global_unlock(void) { \
int i; \ int i; \
rwlock_release(&name##_lock_dep_map, 1, _RET_IP_); \ rwlock_release(&name##_lock_dep_map, 1, _RET_IP_); \
for_each_online_cpu(i) { \ for_each_possible_cpu(i) { \
arch_spinlock_t *lock; \ arch_spinlock_t *lock; \
lock = &per_cpu(name##_lock, i); \ lock = &per_cpu(name##_lock, i); \
arch_spin_unlock(lock); \ arch_spin_unlock(lock); \
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment