Commit a751bd85 authored by Michel Lespinasse's avatar Michel Lespinasse Committed by H. Peter Anvin

x86, rwsem: Stay on fast path when count > 0 in __up_write()

When count > 0 there is no need to take the call_rwsem_wake path.  If
we did take that path, it would just return without doing anything due
to the active count not being zero.
Signed-off-by: default avatarMichel Lespinasse <walken@google.com>
LKML-Reference: <201007202219.o6KMJj9x021042@imap1.linux-foundation.org>
Acked-by: default avatarDavid Howells <dhowells@redhat.com>
Cc: Mike Waychison <mikew@google.com>
Cc: Suleiman Souhlal <suleiman@google.com>
Cc: Ying Han <yinghan@google.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarH. Peter Anvin <hpa@linux.intel.com>
parent e0959371
...@@ -216,9 +216,8 @@ static inline void __up_write(struct rw_semaphore *sem) ...@@ -216,9 +216,8 @@ static inline void __up_write(struct rw_semaphore *sem)
rwsem_count_t tmp; rwsem_count_t tmp;
asm volatile("# beginning __up_write\n\t" asm volatile("# beginning __up_write\n\t"
LOCK_PREFIX " xadd %1,(%2)\n\t" LOCK_PREFIX " xadd %1,(%2)\n\t"
/* tries to transition /* subtracts 0xffff0001, returns the old value */
0xffff0001 -> 0x00000000 */ " jns 1f\n\t"
" jz 1f\n"
" call call_rwsem_wake\n" " call call_rwsem_wake\n"
"1:\n\t" "1:\n\t"
"# ending __up_write\n" "# ending __up_write\n"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment