Commit a7a9456e authored by Amol Grover's avatar Amol Grover Committed by David S. Miller

net: hsr: Pass lockdep expression to RCU lists

node_db is traversed using list_for_each_entry_rcu
outside an RCU read-side critical section but under the protection
of hsr->list_lock.

Hence, add corresponding lockdep expression to silence false-positive
warnings, and harden RCU lists.
Signed-off-by: default avatarAmol Grover <frextrite@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7822dee5
...@@ -155,7 +155,8 @@ static struct hsr_node *hsr_add_node(struct hsr_priv *hsr, ...@@ -155,7 +155,8 @@ static struct hsr_node *hsr_add_node(struct hsr_priv *hsr,
new_node->seq_out[i] = seq_out; new_node->seq_out[i] = seq_out;
spin_lock_bh(&hsr->list_lock); spin_lock_bh(&hsr->list_lock);
list_for_each_entry_rcu(node, node_db, mac_list) { list_for_each_entry_rcu(node, node_db, mac_list,
lockdep_is_held(&hsr->list_lock)) {
if (ether_addr_equal(node->macaddress_A, addr)) if (ether_addr_equal(node->macaddress_A, addr))
goto out; goto out;
if (ether_addr_equal(node->macaddress_B, addr)) if (ether_addr_equal(node->macaddress_B, addr))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment