Commit a8b48e22 authored by Hugo Grostabussiat's avatar Hugo Grostabussiat Committed by Mauro Carvalho Chehab

media: usbtv: Keep norm parameter specific

The user-supplied norm value gets overwritten by the generic .norm
member from the norm_params. That way, we lose the specific norm the
user may want to set.

For instance, if the user specifies V4L2_STD_PAL_60, the value actually
used will be V4L2_STD_525_60, which in the end will be as if the user
had specified V4L2_STD_NTSC, since this is always the first bitfield we
match the norm value against before configuring the hardware.

The norm_params array is only there to match a norm with an output
resolution. The norm value itself should not be changed.
Signed-off-by: default avatarHugo Grostabussiat <bonstra@bonstra.fr.eu.org>
Signed-off-by: default avatarHans Verkuil <hansverk@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent 8c42d276
...@@ -77,7 +77,7 @@ static int usbtv_configure_for_norm(struct usbtv *usbtv, v4l2_std_id norm) ...@@ -77,7 +77,7 @@ static int usbtv_configure_for_norm(struct usbtv *usbtv, v4l2_std_id norm)
usbtv->height = params->cap_height; usbtv->height = params->cap_height;
usbtv->n_chunks = usbtv->width * usbtv->height usbtv->n_chunks = usbtv->width * usbtv->height
/ 4 / USBTV_CHUNK; / 4 / USBTV_CHUNK;
usbtv->norm = params->norm; usbtv->norm = norm;
} else } else
ret = -EINVAL; ret = -EINVAL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment