From a8e9fcec583103b6fca14839fbae353639be10b9 Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman <greg@kroah.com> Date: Tue, 18 May 2004 02:00:39 -0700 Subject: [PATCH] I2C: change i2c_delay() to use msleep() instead. --- drivers/i2c/busses/i2c-ali1535.c | 5 +++-- drivers/i2c/busses/i2c-ali1563.c | 5 +++-- drivers/i2c/busses/i2c-ali15x3.c | 5 +++-- drivers/i2c/busses/i2c-amd756.c | 7 ++++--- drivers/i2c/busses/i2c-amd8111.c | 2 +- drivers/i2c/busses/i2c-i801.c | 7 ++++--- drivers/i2c/busses/i2c-piix4.c | 3 ++- drivers/i2c/busses/i2c-sis5595.c | 3 ++- drivers/i2c/busses/i2c-sis630.c | 3 ++- drivers/i2c/busses/i2c-sis96x.c | 3 ++- drivers/i2c/busses/i2c-viapro.c | 3 ++- drivers/i2c/chips/w83l785ts.c | 3 ++- include/linux/i2c.h | 7 ------- 13 files changed, 30 insertions(+), 26 deletions(-) diff --git a/drivers/i2c/busses/i2c-ali1535.c b/drivers/i2c/busses/i2c-ali1535.c index e7fce45bb061..c0a85e2b8fe4 100644 --- a/drivers/i2c/busses/i2c-ali1535.c +++ b/drivers/i2c/busses/i2c-ali1535.c @@ -59,6 +59,7 @@ #include <linux/kernel.h> #include <linux/stddef.h> #include <linux/sched.h> +#include <linux/delay.h> #include <linux/ioport.h> #include <linux/i2c.h> #include <linux/init.h> @@ -276,7 +277,7 @@ static int ali1535_transaction(struct i2c_adapter *adap) /* We will always wait for a fraction of a second! */ timeout = 0; do { - i2c_delay(1); + msleep(1); temp = inb_p(SMBHSTSTS); } while (((temp & ALI1535_STS_BUSY) && !(temp & ALI1535_STS_IDLE)) && (timeout++ < MAX_TIMEOUT)); @@ -350,7 +351,7 @@ static s32 ali1535_access(struct i2c_adapter *adap, u16 addr, for (timeout = 0; (timeout < MAX_TIMEOUT) && !(temp & ALI1535_STS_IDLE); timeout++) { - i2c_delay(1); + msleep(1); temp = inb_p(SMBHSTSTS); } if (timeout >= MAX_TIMEOUT) diff --git a/drivers/i2c/busses/i2c-ali1563.c b/drivers/i2c/busses/i2c-ali1563.c index 9b55cbbf293e..f77ae846efc4 100644 --- a/drivers/i2c/busses/i2c-ali1563.c +++ b/drivers/i2c/busses/i2c-ali1563.c @@ -16,6 +16,7 @@ */ #include <linux/module.h> +#include <linux/delay.h> #include <linux/i2c.h> #include <linux/pci.h> #include <linux/init.h> @@ -82,7 +83,7 @@ static int ali1563_transaction(struct i2c_adapter * a) timeout = ALI1563_MAX_TIMEOUT; do - i2c_delay(1); + msleep(1); while (((data = inb_p(SMB_HST_STS)) & HST_STS_BUSY) && --timeout); dev_dbg(&a->dev, "Transaction (post): STS=%02x, CNTL1=%02x, " @@ -137,7 +138,7 @@ static int ali1563_block_start(struct i2c_adapter * a) timeout = ALI1563_MAX_TIMEOUT; do - i2c_delay(1); + msleep(1); while (!((data = inb_p(SMB_HST_STS)) & HST_STS_DONE) && --timeout); dev_dbg(&a->dev, "Block (post): STS=%02x, CNTL1=%02x, " diff --git a/drivers/i2c/busses/i2c-ali15x3.c b/drivers/i2c/busses/i2c-ali15x3.c index 673baa5be9d6..ef4a6252442e 100644 --- a/drivers/i2c/busses/i2c-ali15x3.c +++ b/drivers/i2c/busses/i2c-ali15x3.c @@ -67,6 +67,7 @@ #include <linux/stddef.h> #include <linux/sched.h> #include <linux/ioport.h> +#include <linux/delay.h> #include <linux/i2c.h> #include <linux/init.h> #include <asm/io.h> @@ -296,7 +297,7 @@ static int ali15x3_transaction(struct i2c_adapter *adap) /* We will always wait for a fraction of a second! */ timeout = 0; do { - i2c_delay(1); + msleep(1); temp = inb_p(SMBHSTSTS); } while ((!(temp & (ALI15X3_STS_ERR | ALI15X3_STS_DONE))) && (timeout++ < MAX_TIMEOUT)); @@ -353,7 +354,7 @@ static s32 ali15x3_access(struct i2c_adapter * adap, u16 addr, for (timeout = 0; (timeout < MAX_TIMEOUT) && !(temp & ALI15X3_STS_IDLE); timeout++) { - i2c_delay(1); + msleep(1); temp = inb_p(SMBHSTSTS); } if (timeout >= MAX_TIMEOUT) { diff --git a/drivers/i2c/busses/i2c-amd756.c b/drivers/i2c/busses/i2c-amd756.c index 2a273e472948..4b1151373f45 100644 --- a/drivers/i2c/busses/i2c-amd756.c +++ b/drivers/i2c/busses/i2c-amd756.c @@ -41,6 +41,7 @@ #include <linux/module.h> #include <linux/pci.h> #include <linux/kernel.h> +#include <linux/delay.h> #include <linux/stddef.h> #include <linux/sched.h> #include <linux/ioport.h> @@ -124,7 +125,7 @@ static int amd756_transaction(struct i2c_adapter *adap) if ((temp = inw_p(SMB_GLOBAL_STATUS)) & (GS_HST_STS | GS_SMB_STS)) { dev_dbg(&adap->dev, ": SMBus busy (%04x). Waiting... \n", temp); do { - i2c_delay(1); + msleep(1); temp = inw_p(SMB_GLOBAL_STATUS); } while ((temp & (GS_HST_STS | GS_SMB_STS)) && (timeout++ < MAX_TIMEOUT)); @@ -141,7 +142,7 @@ static int amd756_transaction(struct i2c_adapter *adap) /* We will always wait for a fraction of a second! */ do { - i2c_delay(1); + msleep(1); temp = inw_p(SMB_GLOBAL_STATUS); } while ((temp & GS_HST_STS) && (timeout++ < MAX_TIMEOUT)); @@ -188,7 +189,7 @@ static int amd756_transaction(struct i2c_adapter *adap) abort: dev_warn(&adap->dev, ": Sending abort.\n"); outw_p(inw(SMB_GLOBAL_ENABLE) | GE_ABORT, SMB_GLOBAL_ENABLE); - i2c_delay(100); + msleep(100); outw_p(GS_CLEAR_STS, SMB_GLOBAL_STATUS); return -1; } diff --git a/drivers/i2c/busses/i2c-amd8111.c b/drivers/i2c/busses/i2c-amd8111.c index 54704be10404..b0e597049bf0 100644 --- a/drivers/i2c/busses/i2c-amd8111.c +++ b/drivers/i2c/busses/i2c-amd8111.c @@ -276,7 +276,7 @@ s32 amd8111_access(struct i2c_adapter * adap, u16 addr, unsigned short flags, } if (~temp[0] & AMD_SMB_STS_DONE) { - i2c_delay(HZ/100); + msleep(1); amd_ec_read(smbus, AMD_SMB_STS, temp + 0); } diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c index 22c71d7939ab..4689bd01d1c3 100644 --- a/drivers/i2c/busses/i2c-i801.c +++ b/drivers/i2c/busses/i2c-i801.c @@ -44,6 +44,7 @@ #include <linux/pci.h> #include <linux/kernel.h> #include <linux/stddef.h> +#include <linux/delay.h> #include <linux/sched.h> #include <linux/ioport.h> #include <linux/init.h> @@ -207,7 +208,7 @@ static int i801_transaction(void) /* We will always wait for a fraction of a second! */ do { - i2c_delay(1); + msleep(1); temp = inb_p(SMBHSTSTS); } while ((temp & 0x01) && (timeout++ < MAX_TIMEOUT)); @@ -335,7 +336,7 @@ static int i801_block_transaction(union i2c_smbus_data *data, char read_write, timeout = 0; do { temp = inb_p(SMBHSTSTS); - i2c_delay(1); + msleep(1); } while ((!(temp & 0x80)) && (timeout++ < MAX_TIMEOUT)); @@ -395,7 +396,7 @@ static int i801_block_transaction(union i2c_smbus_data *data, char read_write, timeout = 0; do { temp = inb_p(SMBHSTSTS); - i2c_delay(1); + msleep(1); } while ((!(temp & 0x02)) && (timeout++ < MAX_TIMEOUT)); diff --git a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c index 0beca9e9b23d..31ee54341952 100644 --- a/drivers/i2c/busses/i2c-piix4.c +++ b/drivers/i2c/busses/i2c-piix4.c @@ -33,6 +33,7 @@ #include <linux/moduleparam.h> #include <linux/pci.h> #include <linux/kernel.h> +#include <linux/delay.h> #include <linux/stddef.h> #include <linux/sched.h> #include <linux/ioport.h> @@ -260,7 +261,7 @@ static int piix4_transaction(void) /* We will always wait for a fraction of a second! (See PIIX4 docs errata) */ do { - i2c_delay(1); + msleep(1); temp = inb_p(SMBHSTSTS); } while ((temp & 0x01) && (timeout++ < MAX_TIMEOUT)); diff --git a/drivers/i2c/busses/i2c-sis5595.c b/drivers/i2c/busses/i2c-sis5595.c index ec615af7be04..a5040cca3776 100644 --- a/drivers/i2c/busses/i2c-sis5595.c +++ b/drivers/i2c/busses/i2c-sis5595.c @@ -58,6 +58,7 @@ #include <linux/config.h> #include <linux/kernel.h> #include <linux/module.h> +#include <linux/delay.h> #include <linux/pci.h> #include <linux/ioport.h> #include <linux/init.h> @@ -239,7 +240,7 @@ static int sis5595_transaction(struct i2c_adapter *adap) /* We will always wait for a fraction of a second! */ do { - i2c_delay(1); + msleep(1); temp = sis5595_read(SMB_STS_LO); } while (!(temp & 0x40) && (timeout++ < MAX_TIMEOUT)); diff --git a/drivers/i2c/busses/i2c-sis630.c b/drivers/i2c/busses/i2c-sis630.c index b7823c260364..437ee28d3669 100644 --- a/drivers/i2c/busses/i2c-sis630.c +++ b/drivers/i2c/busses/i2c-sis630.c @@ -51,6 +51,7 @@ #include <linux/config.h> #include <linux/kernel.h> #include <linux/module.h> +#include <linux/delay.h> #include <linux/pci.h> #include <linux/ioport.h> #include <linux/init.h> @@ -165,7 +166,7 @@ static int sis630_transaction_wait(struct i2c_adapter *adap, int size) /* We will always wait for a fraction of a second! */ do { - i2c_delay(1); + msleep(1); temp = sis630_read(SMB_STS); /* check if block transmitted */ if (size == SIS630_BLOCK_DATA && (temp & 0x10)) diff --git a/drivers/i2c/busses/i2c-sis96x.c b/drivers/i2c/busses/i2c-sis96x.c index 7c053abcea7a..c71daa347008 100644 --- a/drivers/i2c/busses/i2c-sis96x.c +++ b/drivers/i2c/busses/i2c-sis96x.c @@ -36,6 +36,7 @@ #include <linux/module.h> #include <linux/pci.h> #include <linux/kernel.h> +#include <linux/delay.h> #include <linux/stddef.h> #include <linux/sched.h> #include <linux/ioport.h> @@ -139,7 +140,7 @@ static int sis96x_transaction(int size) /* We will always wait for a fraction of a second! */ do { - i2c_delay(1); + msleep(1); temp = sis96x_read(SMB_STS); } while (!(temp & 0x0e) && (timeout++ < MAX_TIMEOUT)); diff --git a/drivers/i2c/busses/i2c-viapro.c b/drivers/i2c/busses/i2c-viapro.c index fc207253d203..fbd4a15d881c 100644 --- a/drivers/i2c/busses/i2c-viapro.c +++ b/drivers/i2c/busses/i2c-viapro.c @@ -35,6 +35,7 @@ #include <linux/config.h> #include <linux/module.h> +#include <linux/delay.h> #include <linux/pci.h> #include <linux/kernel.h> #include <linux/stddef.h> @@ -138,7 +139,7 @@ static int vt596_transaction(void) /* We will always wait for a fraction of a second! I don't know if VIA needs this, Intel did */ do { - i2c_delay(1); + msleep(1); temp = inb_p(SMBHSTSTS); } while ((temp & 0x01) && (timeout++ < MAX_TIMEOUT)); diff --git a/drivers/i2c/chips/w83l785ts.c b/drivers/i2c/chips/w83l785ts.c index bb7abd315c72..52118f9bf11f 100644 --- a/drivers/i2c/chips/w83l785ts.c +++ b/drivers/i2c/chips/w83l785ts.c @@ -32,6 +32,7 @@ #include <linux/config.h> #include <linux/module.h> +#include <linux/delay.h> #include <linux/init.h> #include <linux/slab.h> #include <linux/i2c.h> @@ -284,7 +285,7 @@ static u8 w83l785ts_read_value(struct i2c_client *client, u8 reg, u8 defval) if (value >= 0) return value; dev_dbg(&client->dev, "Read failed, will retry in %d.\n", i); - i2c_delay(i); + msleep(i); } dev_err(&client->dev, "Couldn't read value from register. " diff --git a/include/linux/i2c.h b/include/linux/i2c.h index 969044dd3f7f..0c3cf0e2fbca 100644 --- a/include/linux/i2c.h +++ b/include/linux/i2c.h @@ -601,11 +601,4 @@ union i2c_smbus_data { #define i2c_is_isa_adapter(adapptr) \ ((adapptr)->algo->id == I2C_ALGO_ISA) -/* Tiny delay function used by the i2c bus drivers */ -static inline void i2c_delay(signed long timeout) -{ - set_current_state(TASK_INTERRUPTIBLE); - schedule_timeout(timeout); -} - #endif /* _LINUX_I2C_H */ -- 2.30.9