Commit ad0ea198 authored by Paolo Abeni's avatar Paolo Abeni Committed by David S. Miller

ipv4: fix broadcast packets reception

Currently, ingress ipv4 broadcast datagrams are dropped since,
in udp_v4_early_demux(), ip_check_mc_rcu() is invoked even on
bcast packets.

This patch addresses the issue, invoking ip_check_mc_rcu()
only for mcast packets.

Fixes: 6e540309 ("ipv4/udp: Verify multicast group is ours in upd_v4_early_demux()")
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
Acked-by: default avatarHannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0419f4a9
...@@ -2070,10 +2070,14 @@ void udp_v4_early_demux(struct sk_buff *skb) ...@@ -2070,10 +2070,14 @@ void udp_v4_early_demux(struct sk_buff *skb)
if (!in_dev) if (!in_dev)
return; return;
ours = ip_check_mc_rcu(in_dev, iph->daddr, iph->saddr, /* we are supposed to accept bcast packets */
iph->protocol); if (skb->pkt_type == PACKET_MULTICAST) {
if (!ours) ours = ip_check_mc_rcu(in_dev, iph->daddr, iph->saddr,
return; iph->protocol);
if (!ours)
return;
}
sk = __udp4_lib_mcast_demux_lookup(net, uh->dest, iph->daddr, sk = __udp4_lib_mcast_demux_lookup(net, uh->dest, iph->daddr,
uh->source, iph->saddr, dif); uh->source, iph->saddr, dif);
} else if (skb->pkt_type == PACKET_HOST) { } else if (skb->pkt_type == PACKET_HOST) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment