Commit afa9e318 authored by Todd Poynor's avatar Todd Poynor Committed by Greg Kroah-Hartman

staging: gasket: apex: convert various logs to debug level

Debugging information is improperly logged at non-debug log level in a
number of places, and some logs regarding error conditions may be
generated too frequently, such that these could cause performance
problems and/or obscure other logs.  Convert these to debug log level.
Signed-off-by: default avatarZhongze Hu <frankhu@chromium.org>
Signed-off-by: default avatarTodd Poynor <toddpoynor@google.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0322bad3
...@@ -420,7 +420,7 @@ static int apex_device_cleanup(struct gasket_dev *gasket_dev) ...@@ -420,7 +420,7 @@ static int apex_device_cleanup(struct gasket_dev *gasket_dev)
gasket_dev, APEX_BAR_INDEX, gasket_dev, APEX_BAR_INDEX,
APEX_BAR2_REG_SCALAR_CORE_ERROR_STATUS); APEX_BAR2_REG_SCALAR_CORE_ERROR_STATUS);
gasket_log_info( gasket_log_debug(
gasket_dev, gasket_dev,
"%s 0x%p hib_error 0x%llx scalar_error " "%s 0x%p hib_error 0x%llx scalar_error "
"0x%llx.", "0x%llx.",
...@@ -589,7 +589,7 @@ static int apex_quit_reset(struct gasket_dev *gasket_dev, uint type) ...@@ -589,7 +589,7 @@ static int apex_quit_reset(struct gasket_dev *gasket_dev, uint type)
SCU3_RG_PWR_STATE_OVR_BIT_OFFSET); SCU3_RG_PWR_STATE_OVR_BIT_OFFSET);
val1 = gasket_dev_read_32( val1 = gasket_dev_read_32(
gasket_dev, APEX_BAR_INDEX, APEX_BAR2_REG_SCU_3); gasket_dev, APEX_BAR_INDEX, APEX_BAR2_REG_SCU_3);
gasket_log_error( gasket_log_debug(
gasket_dev, "Disallow HW clock gating 0x%x -> 0x%x", gasket_dev, "Disallow HW clock gating 0x%x -> 0x%x",
val0, val1); val0, val1);
} else { } else {
...@@ -602,7 +602,7 @@ static int apex_quit_reset(struct gasket_dev *gasket_dev, uint type) ...@@ -602,7 +602,7 @@ static int apex_quit_reset(struct gasket_dev *gasket_dev, uint type)
SCU3_RG_PWR_STATE_OVR_BIT_OFFSET); SCU3_RG_PWR_STATE_OVR_BIT_OFFSET);
val1 = gasket_dev_read_32( val1 = gasket_dev_read_32(
gasket_dev, APEX_BAR_INDEX, APEX_BAR2_REG_SCU_3); gasket_dev, APEX_BAR_INDEX, APEX_BAR2_REG_SCU_3);
gasket_log_error( gasket_log_debug(
gasket_dev, "Allow HW clock gating 0x%x -> 0x%x", val0, gasket_dev, "Allow HW clock gating 0x%x -> 0x%x", val0,
val1); val1);
} }
...@@ -668,7 +668,7 @@ static long apex_clock_gating(struct gasket_dev *gasket_dev, ...@@ -668,7 +668,7 @@ static long apex_clock_gating(struct gasket_dev *gasket_dev,
if (copy_from_user(&ibuf, argp, sizeof(ibuf))) if (copy_from_user(&ibuf, argp, sizeof(ibuf)))
return -EFAULT; return -EFAULT;
gasket_log_error(gasket_dev, "%s %llu", __func__, ibuf.enable); gasket_log_debug(gasket_dev, "%s %llu", __func__, ibuf.enable);
if (ibuf.enable) { if (ibuf.enable) {
/* Quiesce AXI, gate GCB clock. */ /* Quiesce AXI, gate GCB clock. */
...@@ -738,7 +738,7 @@ static ssize_t sysfs_show( ...@@ -738,7 +738,7 @@ static ssize_t sysfs_show(
gasket_dev->page_table[0])); gasket_dev->page_table[0]));
break; break;
default: default:
gasket_log_error( gasket_log_debug(
gasket_dev, "Unknown attribute: %s", attr->attr.name); gasket_dev, "Unknown attribute: %s", attr->attr.name);
ret = 0; ret = 0;
break; break;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment