Commit b10a4a9f authored by Al Viro's avatar Al Viro

create_pipe_files(): use fput() if allocation of the second file fails

... just use put_pipe_info() to get the pipe->files down to 1 and let
fput()-called pipe_release() do freeing.
Acked-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 19f391eb
...@@ -771,8 +771,9 @@ int create_pipe_files(struct file **res, int flags) ...@@ -771,8 +771,9 @@ int create_pipe_files(struct file **res, int flags)
res[0] = alloc_file(&path, FMODE_READ, &pipefifo_fops); res[0] = alloc_file(&path, FMODE_READ, &pipefifo_fops);
if (IS_ERR(res[0])) { if (IS_ERR(res[0])) {
err = PTR_ERR(res[0]); put_pipe_info(inode, inode->i_pipe);
goto err_file; fput(f);
return PTR_ERR(res[0]);
} }
path_get(&path); path_get(&path);
...@@ -781,8 +782,6 @@ int create_pipe_files(struct file **res, int flags) ...@@ -781,8 +782,6 @@ int create_pipe_files(struct file **res, int flags)
res[1] = f; res[1] = f;
return 0; return 0;
err_file:
put_filp(f);
err_dentry: err_dentry:
free_pipe_info(inode->i_pipe); free_pipe_info(inode->i_pipe);
path_put(&path); path_put(&path);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment