Commit b2969960 authored by Alex Elder's avatar Alex Elder Committed by Greg Kroah-Hartman

greybus: drop the cport id on error

In gb_connection_create(), if an error occurs adding a connection's
device, the cport id assigned to the AP end of the connection is not
getting freed.  Fix that.
Signed-off-by: default avatarAlex Elder <elder@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <greg@kroah.com>
parent 755a21a9
...@@ -186,6 +186,8 @@ struct gb_connection *gb_connection_create(struct gb_interface *interface, ...@@ -186,6 +186,8 @@ struct gb_connection *gb_connection_create(struct gb_interface *interface,
retval = device_add(&connection->dev); retval = device_add(&connection->dev);
if (retval) { if (retval) {
gb_connection_hd_cport_id_free(connection);
/* kref_put(connection->hd); */
kfree(connection); kfree(connection);
return NULL; return NULL;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment