Commit b820d52e authored by Wen Yang's avatar Wen Yang Committed by Mark Brown

ASoC: eukrea-tlv320: fix a leaked reference by adding missing of_node_put

The call to of_parse_phandle returns a node pointer with refcount
incremented thus it must be explicitly decremented after the last
usage.

Detected by coccinelle with the following warnings:
./sound/soc/fsl/eukrea-tlv320.c:121:3-9: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 102, but without a correspo    nding object release within this function.
./sound/soc/fsl/eukrea-tlv320.c:127:3-9: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 102, but without a correspo    nding object release within this function.
Signed-off-by: default avatarWen Yang <wen.yang99@zte.com.cn>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.com>
Cc: alsa-devel@alsa-project.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent c7052471
...@@ -118,13 +118,13 @@ static int eukrea_tlv320_probe(struct platform_device *pdev) ...@@ -118,13 +118,13 @@ static int eukrea_tlv320_probe(struct platform_device *pdev)
if (ret) { if (ret) {
dev_err(&pdev->dev, dev_err(&pdev->dev,
"fsl,mux-int-port node missing or invalid.\n"); "fsl,mux-int-port node missing or invalid.\n");
return ret; goto err;
} }
ret = of_property_read_u32(np, "fsl,mux-ext-port", &ext_port); ret = of_property_read_u32(np, "fsl,mux-ext-port", &ext_port);
if (ret) { if (ret) {
dev_err(&pdev->dev, dev_err(&pdev->dev,
"fsl,mux-ext-port node missing or invalid.\n"); "fsl,mux-ext-port node missing or invalid.\n");
return ret; goto err;
} }
/* /*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment