Commit b8a31c9a authored by Felix Fietkau's avatar Felix Fietkau Committed by Johannes Berg

ieee80211: mark 802.11 related structs as being 2-byte aligned

Regardless of what header features they use, or if they align the IP
header or not, 802.11 packets from all drivers guarantee a 2-byte
alignment (and there's a debug WARN_ON in case they don't).

Annotate packet structs with __aligned(2) to allow the compiler to use
16-bit load/store operations on platforms with extremely inefficient
unaligned access (e.g. MIPS).

This reduces code size and improves performance on affected platforms
and causes no binary code change on others.
Signed-off-by: default avatarFelix Fietkau <nbd@openwrt.org>
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 9a886586
...@@ -213,7 +213,7 @@ struct ieee80211_hdr { ...@@ -213,7 +213,7 @@ struct ieee80211_hdr {
u8 addr3[6]; u8 addr3[6];
__le16 seq_ctrl; __le16 seq_ctrl;
u8 addr4[6]; u8 addr4[6];
} __packed; } __packed __aligned(2);
struct ieee80211_hdr_3addr { struct ieee80211_hdr_3addr {
__le16 frame_control; __le16 frame_control;
...@@ -222,7 +222,7 @@ struct ieee80211_hdr_3addr { ...@@ -222,7 +222,7 @@ struct ieee80211_hdr_3addr {
u8 addr2[6]; u8 addr2[6];
u8 addr3[6]; u8 addr3[6];
__le16 seq_ctrl; __le16 seq_ctrl;
} __packed; } __packed __aligned(2);
struct ieee80211_qos_hdr { struct ieee80211_qos_hdr {
__le16 frame_control; __le16 frame_control;
...@@ -232,7 +232,7 @@ struct ieee80211_qos_hdr { ...@@ -232,7 +232,7 @@ struct ieee80211_qos_hdr {
u8 addr3[6]; u8 addr3[6];
__le16 seq_ctrl; __le16 seq_ctrl;
__le16 qos_ctrl; __le16 qos_ctrl;
} __packed; } __packed __aligned(2);
/** /**
* ieee80211_has_tods - check if IEEE80211_FCTL_TODS is set * ieee80211_has_tods - check if IEEE80211_FCTL_TODS is set
...@@ -609,7 +609,7 @@ struct ieee80211s_hdr { ...@@ -609,7 +609,7 @@ struct ieee80211s_hdr {
__le32 seqnum; __le32 seqnum;
u8 eaddr1[6]; u8 eaddr1[6];
u8 eaddr2[6]; u8 eaddr2[6];
} __packed; } __packed __aligned(2);
/* Mesh flags */ /* Mesh flags */
#define MESH_FLAGS_AE_A4 0x1 #define MESH_FLAGS_AE_A4 0x1
...@@ -903,7 +903,7 @@ struct ieee80211_mgmt { ...@@ -903,7 +903,7 @@ struct ieee80211_mgmt {
} u; } u;
} __packed action; } __packed action;
} u; } u;
} __packed; } __packed __aligned(2);
/* Supported Rates value encodings in 802.11n-2009 7.3.2.2 */ /* Supported Rates value encodings in 802.11n-2009 7.3.2.2 */
#define BSS_MEMBERSHIP_SELECTOR_HT_PHY 127 #define BSS_MEMBERSHIP_SELECTOR_HT_PHY 127
...@@ -934,20 +934,20 @@ struct ieee80211_rts { ...@@ -934,20 +934,20 @@ struct ieee80211_rts {
__le16 duration; __le16 duration;
u8 ra[6]; u8 ra[6];
u8 ta[6]; u8 ta[6];
} __packed; } __packed __aligned(2);
struct ieee80211_cts { struct ieee80211_cts {
__le16 frame_control; __le16 frame_control;
__le16 duration; __le16 duration;
u8 ra[6]; u8 ra[6];
} __packed; } __packed __aligned(2);
struct ieee80211_pspoll { struct ieee80211_pspoll {
__le16 frame_control; __le16 frame_control;
__le16 aid; __le16 aid;
u8 bssid[6]; u8 bssid[6];
u8 ta[6]; u8 ta[6];
} __packed; } __packed __aligned(2);
/* TDLS */ /* TDLS */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment