Commit b94901f3 authored by Eyal Perry's avatar Eyal Perry Committed by David S. Miller

net/mlx4_en: current_mac isn't updated in port up

When port is down dev_addr is changed (e.g. by bonding) but current_mac
is not touched. When port is up again, hash_mac is updated to dev_addr,
but current_mac isn't. This leads to inconsistency between current_mac
and mac_hash. Because of that, mlx4_en_replace_mac() fails to find
current_mac in mac_hash.

Fix is to reset current_mac to dev_addr when port is up - as we do for
mac_hash.
Signed-off-by: default avatarEyal Perry <eyalpe@mellanox.com>
Signed-off-by: default avatarAmir Vadai <amirv@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7861f12b
...@@ -644,6 +644,7 @@ static int mlx4_en_get_qp(struct mlx4_en_priv *priv) ...@@ -644,6 +644,7 @@ static int mlx4_en_get_qp(struct mlx4_en_priv *priv)
goto alloc_err; goto alloc_err;
} }
memcpy(entry->mac, priv->dev->dev_addr, sizeof(entry->mac)); memcpy(entry->mac, priv->dev->dev_addr, sizeof(entry->mac));
memcpy(priv->current_mac, entry->mac, sizeof(priv->current_mac));
entry->reg_id = reg_id; entry->reg_id = reg_id;
hlist_add_head_rcu(&entry->hlist, hlist_add_head_rcu(&entry->hlist,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment