Commit b98acbff authored by Colin Ian King's avatar Colin Ian King Committed by Mark Brown

regulator: twl6030: fix range comparison, allowing vsel = 59

The range min_uV > 1350000 && min_uV <= 150000 is never reachable
because of a typo in the previous range check and hence vsel = 59
is never reached.  Fix the previous range check to enable the
vsel = 59 setting.

Fixes CoverityScan CID#728454 ("Logially dead code")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent d00b7461
...@@ -452,7 +452,7 @@ static int twl6030smps_map_voltage(struct regulator_dev *rdev, int min_uV, ...@@ -452,7 +452,7 @@ static int twl6030smps_map_voltage(struct regulator_dev *rdev, int min_uV,
vsel = 62; vsel = 62;
else if ((min_uV > 1800000) && (min_uV <= 1900000)) else if ((min_uV > 1800000) && (min_uV <= 1900000))
vsel = 61; vsel = 61;
else if ((min_uV > 1350000) && (min_uV <= 1800000)) else if ((min_uV > 1500000) && (min_uV <= 1800000))
vsel = 60; vsel = 60;
else if ((min_uV > 1350000) && (min_uV <= 1500000)) else if ((min_uV > 1350000) && (min_uV <= 1500000))
vsel = 59; vsel = 59;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment