Commit bb7e73c5 authored by Mark Deneen's avatar Mark Deneen Committed by Greg Kroah-Hartman

tty/serial: at91: reset rx_ring when port is shutdown

When using RX DMA, the driver won't pass any data to the uart layer
until the buffer is flipped. When the port is shutdown, the dma buffers
are unmapped, but the head and tail of the ring buffer are not reseted.
Since the serial console will keep the port open, this will only
present itself when the uart is not shared.

To reproduce the issue, with an unpatched driver, run a getty on /dev/ttyS0
with no serial console and exit. Getty will exit, and when the new one returns
you will be unable to log in.  If you hold down a key long enough to fill the
DMA buffer and flip it, you can then log in.
Signed-off-by: default avatarMark Deneen <mdeneen@gmail.com>
Acked-by: default avatarLeilei Zhao <leilei.zhao@atmel.com>
[nicolas.ferre@atmel.com: adapt to mainline kernel, handle !DMA case]
Cc: <stable@vger.kernel.org> # v3.12
Signed-off-by: default avatarNicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f50c995f
...@@ -1676,6 +1676,12 @@ static void atmel_shutdown(struct uart_port *port) ...@@ -1676,6 +1676,12 @@ static void atmel_shutdown(struct uart_port *port)
if (atmel_port->release_tx) if (atmel_port->release_tx)
atmel_port->release_tx(port); atmel_port->release_tx(port);
/*
* Reset ring buffer pointers
*/
atmel_port->rx_ring.head = 0;
atmel_port->rx_ring.tail = 0;
/* /*
* Free the interrupt * Free the interrupt
*/ */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment