Commit bd16693f authored by Peter Oskolkov's avatar Peter Oskolkov Committed by David S. Miller

net: fix double-free in bpf_lwt_xmit_reroute

dst_output() frees skb when it fails (see, for example,
ip_finish_output2), so it must not be freed in this case.

Fixes: 3bd0b152 ("bpf: add handling of BPF_LWT_REROUTE to lwt_bpf.c")
Signed-off-by: default avatarPeter Oskolkov <posk@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 186d9366
...@@ -260,7 +260,7 @@ static int bpf_lwt_xmit_reroute(struct sk_buff *skb) ...@@ -260,7 +260,7 @@ static int bpf_lwt_xmit_reroute(struct sk_buff *skb)
err = dst_output(dev_net(skb_dst(skb)->dev), skb->sk, skb); err = dst_output(dev_net(skb_dst(skb)->dev), skb->sk, skb);
if (unlikely(err)) if (unlikely(err))
goto err; return err;
/* ip[6]_finish_output2 understand LWTUNNEL_XMIT_DONE */ /* ip[6]_finish_output2 understand LWTUNNEL_XMIT_DONE */
return LWTUNNEL_XMIT_DONE; return LWTUNNEL_XMIT_DONE;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment