Commit be73a347 authored by Guennadi Liakhovetski's avatar Guennadi Liakhovetski Committed by Russell King

[ARM] 4845/1: Orion: Ignore memory tags with invalid data

The DNS-323, Kurobox-Pro / Linkstation-Pro, QNAP TS-109/TS-209 and some
other orion-based systems have several bogus memory entries in the tag
table, which causes the system to crash at startup. Ignore them by
resetting the tag ID to 0 in a machine fixup function.
Signed-off-by: default avatarGuennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
parent 29e8c3c3
...@@ -17,7 +17,9 @@ ...@@ -17,7 +17,9 @@
#include <linux/mv643xx_eth.h> #include <linux/mv643xx_eth.h>
#include <linux/mv643xx_i2c.h> #include <linux/mv643xx_i2c.h>
#include <asm/page.h> #include <asm/page.h>
#include <asm/setup.h>
#include <asm/timex.h> #include <asm/timex.h>
#include <asm/mach/arch.h>
#include <asm/mach/map.h> #include <asm/mach/map.h>
#include <asm/arch/hardware.h> #include <asm/arch/hardware.h>
#include "common.h" #include "common.h"
...@@ -347,3 +349,21 @@ void __init orion_init(void) ...@@ -347,3 +349,21 @@ void __init orion_init(void)
platform_device_register(&orion_ehci1); platform_device_register(&orion_ehci1);
platform_device_register(&orion_i2c); platform_device_register(&orion_i2c);
} }
/*
* Many orion-based systems have buggy bootloader implementations.
* This is a common fixup for bogus memory tags.
*/
void __init tag_fixup_mem32(struct machine_desc *mdesc, struct tag *t,
char **from, struct meminfo *meminfo)
{
for (; t->hdr.size; t = tag_next(t))
if (t->hdr.tag == ATAG_MEM &&
(!t->u.mem.size || t->u.mem.size & ~PAGE_MASK ||
t->u.mem.start & ~PAGE_MASK)) {
printk(KERN_WARNING
"Clearing invalid memory bank %dKB@0x%08x\n",
t->u.mem.size / 1024, t->u.mem.start);
t->hdr.tag = 0;
}
}
...@@ -83,4 +83,10 @@ struct mv_sata_platform_data; ...@@ -83,4 +83,10 @@ struct mv_sata_platform_data;
void __init orion_sata_init(struct mv_sata_platform_data *sata_data); void __init orion_sata_init(struct mv_sata_platform_data *sata_data);
struct machine_desc;
struct meminfo;
struct tag;
extern void __init tag_fixup_mem32(struct machine_desc *, struct tag *,
char **, struct meminfo *);
#endif /* __ARCH_ORION_COMMON_H__ */ #endif /* __ARCH_ORION_COMMON_H__ */
...@@ -319,4 +319,5 @@ MACHINE_START(DNS323, "D-Link DNS-323") ...@@ -319,4 +319,5 @@ MACHINE_START(DNS323, "D-Link DNS-323")
.map_io = orion_map_io, .map_io = orion_map_io,
.init_irq = orion_init_irq, .init_irq = orion_init_irq,
.timer = &orion_timer, .timer = &orion_timer,
.fixup = tag_fixup_mem32,
MACHINE_END MACHINE_END
...@@ -240,4 +240,5 @@ MACHINE_START(KUROBOX_PRO, "Buffalo/Revogear Kurobox Pro") ...@@ -240,4 +240,5 @@ MACHINE_START(KUROBOX_PRO, "Buffalo/Revogear Kurobox Pro")
.map_io = orion_map_io, .map_io = orion_map_io,
.init_irq = orion_init_irq, .init_irq = orion_init_irq,
.timer = &orion_timer, .timer = &orion_timer,
.fixup = tag_fixup_mem32,
MACHINE_END MACHINE_END
...@@ -357,4 +357,5 @@ MACHINE_START(TS209, "QNAP TS-109/TS-209") ...@@ -357,4 +357,5 @@ MACHINE_START(TS209, "QNAP TS-109/TS-209")
.map_io = orion_map_io, .map_io = orion_map_io,
.init_irq = orion_init_irq, .init_irq = orion_init_irq,
.timer = &orion_timer, .timer = &orion_timer,
.fixup = tag_fixup_mem32,
MACHINE_END MACHINE_END
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment