Commit c1adab97 authored by Michal Wajdeczko's avatar Michal Wajdeczko Committed by Chris Wilson

drm/i915/guc: Remove failed doorbell stat from debugfs

This stat is almost always zero unless fatal error occurs,
which should be reported by other means anyway.
Suggested-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: default avatarMichal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20170518113104.54400-2-michal.wajdeczko@intel.comReviewed-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
parent 4afc67be
...@@ -2482,7 +2482,6 @@ static void i915_guc_client_info(struct seq_file *m, ...@@ -2482,7 +2482,6 @@ static void i915_guc_client_info(struct seq_file *m,
client->wq_size, client->wq_offset, client->wq_tail); client->wq_size, client->wq_offset, client->wq_tail);
seq_printf(m, "\tWork queue full: %u\n", client->no_wq_space); seq_printf(m, "\tWork queue full: %u\n", client->no_wq_space);
seq_printf(m, "\tFailed doorbell: %u\n", client->b_fail);
seq_printf(m, "\tLast submission result: %d\n", client->retcode); seq_printf(m, "\tLast submission result: %d\n", client->retcode);
for_each_engine(engine, dev_priv, id) { for_each_engine(engine, dev_priv, id) {
......
...@@ -615,8 +615,6 @@ static void __i915_guc_submit(struct drm_i915_gem_request *rq) ...@@ -615,8 +615,6 @@ static void __i915_guc_submit(struct drm_i915_gem_request *rq)
client->submissions[engine_id] += 1; client->submissions[engine_id] += 1;
client->retcode = b_ret; client->retcode = b_ret;
if (b_ret)
client->b_fail += 1;
guc->submissions[engine_id] += 1; guc->submissions[engine_id] += 1;
guc->last_seqno[engine_id] = rq->global_seqno; guc->last_seqno[engine_id] = rq->global_seqno;
......
...@@ -59,9 +59,6 @@ struct drm_i915_gem_request; ...@@ -59,9 +59,6 @@ struct drm_i915_gem_request;
* available in the work queue (note, the queue is shared, * available in the work queue (note, the queue is shared,
* not per-engine). It is OK for this to be nonzero, but * not per-engine). It is OK for this to be nonzero, but
* it should not be huge! * it should not be huge!
* b_fail: failed to ring the doorbell. This should never happen, unless
* somehow the hardware misbehaves, or maybe if the GuC firmware
* crashes? We probably need to reset the GPU to recover.
* retcode: errno from last guc_submit() * retcode: errno from last guc_submit()
*/ */
struct i915_guc_client { struct i915_guc_client {
...@@ -85,7 +82,6 @@ struct i915_guc_client { ...@@ -85,7 +82,6 @@ struct i915_guc_client {
uint32_t wq_tail; uint32_t wq_tail;
uint32_t wq_rsvd; uint32_t wq_rsvd;
uint32_t no_wq_space; uint32_t no_wq_space;
uint32_t b_fail;
int retcode; int retcode;
/* Per-engine counts of GuC submissions */ /* Per-engine counts of GuC submissions */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment