Commit c3edc401 authored by Ingo Molnar's avatar Ingo Molnar

sched/headers: Move task_struct::signal and task_struct::sighand types and...

sched/headers: Move task_struct::signal and task_struct::sighand types and accessors into <linux/sched/signal.h>

task_struct::signal and task_struct::sighand are pointers, which would normally make it
straightforward to not define those types in sched.h.

That is not so, because the types are accompanied by a myriad of APIs (macros and inline
functions) that dereference them.

Split the types and the APIs out of sched.h and move them into a new header, <linux/sched/signal.h>.

With this change sched.h does not know about 'struct signal' and 'struct sighand' anymore,
trying to put accessors into sched.h as a test fails the following way:

  ./include/linux/sched.h: In function ‘test_signal_types’:
  ./include/linux/sched.h:2461:18: error: dereferencing pointer to incomplete type ‘struct signal_struct’
                    ^

This reduces the size and complexity of sched.h significantly.

Update all headers and .c code that relied on getting the signal handling
functionality from <linux/sched.h> to include <linux/sched/signal.h>.

The list of affected files in the preparatory patch was partly generated by
grepping for the APIs, and partly by doing coverage build testing, both
all[yes|mod|def|no]config builds on 64-bit and 32-bit x86, and an array of
cross-architecture builds.

Nevertheless some (trivial) build breakage is still expected related to rare
Kconfig combinations and in-flight patches to various kernel code, but most
of it should be handled by this patch.
Acked-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 11701c67
...@@ -31,7 +31,7 @@ ...@@ -31,7 +31,7 @@
#include <linux/types.h> #include <linux/types.h>
#include <linux/kernel.h> #include <linux/kernel.h>
#include <linux/signal.h> #include <linux/signal.h>
#include <linux/sched.h> #include <linux/sched/signal.h>
#include <linux/init.h> #include <linux/init.h>
#include <asm/thread_notify.h> #include <asm/thread_notify.h>
......
...@@ -10,8 +10,7 @@ ...@@ -10,8 +10,7 @@
* *
* FIXME! These routines have not been tested for big endian case. * FIXME! These routines have not been tested for big endian case.
*/ */
#include <linux/sched.h> #include <linux/sched/signal.h>
#include <linux/signal.h>
#include <linux/io.h> #include <linux/io.h>
#include <cpu/fpu.h> #include <cpu/fpu.h>
#include <asm/processor.h> #include <asm/processor.h>
......
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
#include <linux/module.h> #include <linux/module.h>
#include <linux/skbuff.h> #include <linux/skbuff.h>
#include <linux/cache.h> #include <linux/cache.h>
#include <linux/sched.h> #include <linux/sched/signal.h>
#include <linux/types.h> #include <linux/types.h>
#include <linux/slab.h> #include <linux/slab.h>
#include <linux/wait.h> #include <linux/wait.h>
......
This diff is collapsed.
This diff is collapsed.
...@@ -5,6 +5,7 @@ ...@@ -5,6 +5,7 @@
#include <linux/sort.h> #include <linux/sort.h>
#include <linux/delay.h> #include <linux/delay.h>
#include <linux/mm.h> #include <linux/mm.h>
#include <linux/sched/signal.h>
#include <linux/slab.h> #include <linux/slab.h>
#include <linux/vmalloc.h> #include <linux/vmalloc.h>
#include <linux/delayacct.h> #include <linux/delayacct.h>
......
...@@ -12,7 +12,7 @@ ...@@ -12,7 +12,7 @@
#include <linux/mm.h> #include <linux/mm.h>
#include <linux/module.h> #include <linux/module.h>
#include <linux/highmem.h> #include <linux/highmem.h>
#include <linux/sched.h> #include <linux/sched/signal.h>
#include <linux/slab.h> #include <linux/slab.h>
#include <linux/spinlock.h> #include <linux/spinlock.h>
#include <linux/interrupt.h> #include <linux/interrupt.h>
......
...@@ -27,6 +27,8 @@ ...@@ -27,6 +27,8 @@
#include <linux/inetdevice.h> #include <linux/inetdevice.h>
#include <linux/workqueue.h> #include <linux/workqueue.h>
#include <linux/in.h> #include <linux/in.h>
#include <linux/sched/signal.h>
#include <net/sock.h> #include <net/sock.h>
#include <net/tcp.h> #include <net/tcp.h>
#include <net/smc.h> #include <net/smc.h>
......
...@@ -11,6 +11,8 @@ ...@@ -11,6 +11,8 @@
#include <linux/in.h> #include <linux/in.h>
#include <linux/if_ether.h> #include <linux/if_ether.h>
#include <linux/sched/signal.h>
#include <net/sock.h> #include <net/sock.h>
#include <net/tcp.h> #include <net/tcp.h>
......
...@@ -9,6 +9,8 @@ ...@@ -9,6 +9,8 @@
*/ */
#include <linux/workqueue.h> #include <linux/workqueue.h>
#include <linux/sched/signal.h>
#include <net/sock.h> #include <net/sock.h>
#include "smc.h" #include "smc.h"
......
...@@ -11,6 +11,8 @@ ...@@ -11,6 +11,8 @@
#include <linux/net.h> #include <linux/net.h>
#include <linux/rcupdate.h> #include <linux/rcupdate.h>
#include <linux/sched/signal.h>
#include <net/sock.h> #include <net/sock.h>
#include "smc.h" #include "smc.h"
......
...@@ -15,6 +15,8 @@ ...@@ -15,6 +15,8 @@
#include <linux/net.h> #include <linux/net.h>
#include <linux/rcupdate.h> #include <linux/rcupdate.h>
#include <linux/workqueue.h> #include <linux/workqueue.h>
#include <linux/sched/signal.h>
#include <net/sock.h> #include <net/sock.h>
#include "smc.h" #include "smc.h"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment