Commit c4c0edfb authored by Julia Lawall's avatar Julia Lawall Committed by Sebastian Reichel

power/reset: at91-reset: add missing of_node_put

for_each_matching_node performs an of_node_get on each iteration, so
a break out of the loop requires an of_node_put.

A simplified version of the semantic patch that fixes this problem is as
follows (http://coccinelle.lip6.fr):

// <smpl>
@@
expression e,e1;
local idexpression np;
@@

 for_each_matching_node(np, e1) {
   ... when != of_node_put(np)
       when != e = np
(
   return np;
|
+  of_node_put(np);
?  return ...;
)
   ...
 }
// </smpl>
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarSebastian Reichel <sre@kernel.org>
parent 79fbdb66
...@@ -198,6 +198,7 @@ static int __init at91_reset_probe(struct platform_device *pdev) ...@@ -198,6 +198,7 @@ static int __init at91_reset_probe(struct platform_device *pdev)
at91_ramc_base[idx] = of_iomap(np, 0); at91_ramc_base[idx] = of_iomap(np, 0);
if (!at91_ramc_base[idx]) { if (!at91_ramc_base[idx]) {
dev_err(&pdev->dev, "Could not map ram controller address\n"); dev_err(&pdev->dev, "Could not map ram controller address\n");
of_node_put(np);
return -ENODEV; return -ENODEV;
} }
idx++; idx++;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment