Commit c65a9656 authored by Peter Senna Tschudin's avatar Peter Senna Tschudin Committed by David S. Miller

via-ircc: Remove useless return variables

This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.

Verified by compilation only.

The coccinelle script that find and fixes this issue is:
// <smpl>
@@
type T;
constant C;
identifier ret;
@@
- T ret = C;
... when != ret
    when strict
return
- ret
+ C
;
// </smpl>
Signed-off-by: default avatarPeter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 8db4ec66
...@@ -510,10 +510,8 @@ static void via_hw_init(struct via_ircc_cb *self) ...@@ -510,10 +510,8 @@ static void via_hw_init(struct via_ircc_cb *self)
*/ */
static int via_ircc_read_dongle_id(int iobase) static int via_ircc_read_dongle_id(int iobase)
{ {
int dongle_id = 9; /* Default to IBM */
IRDA_ERROR("via-ircc: dongle probing not supported, please specify dongle_id module parameter.\n"); IRDA_ERROR("via-ircc: dongle probing not supported, please specify dongle_id module parameter.\n");
return dongle_id; return 9; /* Default to IBM */
} }
/* /*
...@@ -926,7 +924,6 @@ static int via_ircc_dma_xmit(struct via_ircc_cb *self, u16 iobase) ...@@ -926,7 +924,6 @@ static int via_ircc_dma_xmit(struct via_ircc_cb *self, u16 iobase)
static int via_ircc_dma_xmit_complete(struct via_ircc_cb *self) static int via_ircc_dma_xmit_complete(struct via_ircc_cb *self)
{ {
int iobase; int iobase;
int ret = TRUE;
u8 Tx_status; u8 Tx_status;
IRDA_DEBUG(3, "%s()\n", __func__); IRDA_DEBUG(3, "%s()\n", __func__);
...@@ -983,7 +980,7 @@ F01_E*/ ...@@ -983,7 +980,7 @@ F01_E*/
// Tell the network layer, that we can accept more frames // Tell the network layer, that we can accept more frames
netif_wake_queue(self->netdev); netif_wake_queue(self->netdev);
//F01 } //F01 }
return ret; return TRUE;
} }
/* /*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment