Commit c6d64a19 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman

greybus: connection: drop the connection_mutex

Drop the useless connection_mutex that did not, and can not be used to
prevent connection lookup races in atomic context and therefore serves
no purpose.
Reviewed-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: default avatarJohan Hovold <johan@hovoldconsulting.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@google.com>
parent c3681f6c
...@@ -66,8 +66,6 @@ void greybus_data_rcvd(struct gb_host_device *hd, u16 cport_id, ...@@ -66,8 +66,6 @@ void greybus_data_rcvd(struct gb_host_device *hd, u16 cport_id,
} }
EXPORT_SYMBOL_GPL(greybus_data_rcvd); EXPORT_SYMBOL_GPL(greybus_data_rcvd);
static DEFINE_MUTEX(connection_mutex);
static void gb_connection_kref_release(struct kref *kref) static void gb_connection_kref_release(struct kref *kref)
{ {
struct gb_connection *connection; struct gb_connection *connection;
...@@ -75,7 +73,6 @@ static void gb_connection_kref_release(struct kref *kref) ...@@ -75,7 +73,6 @@ static void gb_connection_kref_release(struct kref *kref)
connection = container_of(kref, struct gb_connection, kref); connection = container_of(kref, struct gb_connection, kref);
kfree(connection); kfree(connection);
mutex_unlock(&connection_mutex);
} }
static void gb_connection_init_name(struct gb_connection *connection) static void gb_connection_init_name(struct gb_connection *connection)
...@@ -519,8 +516,7 @@ void gb_connection_destroy(struct gb_connection *connection) ...@@ -519,8 +516,7 @@ void gb_connection_destroy(struct gb_connection *connection)
ida_simple_remove(id_map, connection->hd_cport_id); ida_simple_remove(id_map, connection->hd_cport_id);
connection->hd_cport_id = CPORT_ID_BAD; connection->hd_cport_id = CPORT_ID_BAD;
kref_put_mutex(&connection->kref, gb_connection_kref_release, kref_put(&connection->kref, gb_connection_kref_release);
&connection_mutex);
} }
void gb_connection_latency_tag_enable(struct gb_connection *connection) void gb_connection_latency_tag_enable(struct gb_connection *connection)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment