Commit c9a5e6a9 authored by Mike Snitzer's avatar Mike Snitzer

dm snapshot: remove stale FIXME in snapshot_map()

Commit ae1093be ("dm snapshot: use mutex instead of rw_semaphore")
eliminated the need to worry about read vs write locking.  So remove a
FIXME in snapshot_map() that is concerned about selectively taking a
write lock.
Signed-off-by: default avatarMike Snitzer <snitzer@redhat.com>
parent 3db2776d
...@@ -1707,8 +1707,6 @@ static int snapshot_map(struct dm_target *ti, struct bio *bio) ...@@ -1707,8 +1707,6 @@ static int snapshot_map(struct dm_target *ti, struct bio *bio)
if (!s->valid) if (!s->valid)
return DM_MAPIO_KILL; return DM_MAPIO_KILL;
/* FIXME: should only take write lock if we need
* to copy an exception */
mutex_lock(&s->lock); mutex_lock(&s->lock);
if (!s->valid || (unlikely(s->snapshot_overflowed) && if (!s->valid || (unlikely(s->snapshot_overflowed) &&
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment