Commit cb60610a authored by Xiongfeng Wang's avatar Xiongfeng Wang Committed by Jonathan Cameron

iio: accel: use strlcpy() instead of strncpy()

gcc-8 reports

drivers/iio/accel/st_accel_i2c.c: In function 'st_accel_i2c_probe':
./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified
bound 20 equals destination size [-Wstringop-truncation]

The compiler require that the length of the dest string is greater than
the length we want to copy to make sure the dest string is
nul-terminated. We can just use strlcpy() to avoid this warning.
Signed-off-by: default avatarXiongfeng Wang <xiongfeng.wang@linaro.org>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent a66a4e8e
...@@ -159,9 +159,8 @@ static int st_accel_i2c_probe(struct i2c_client *client, ...@@ -159,9 +159,8 @@ static int st_accel_i2c_probe(struct i2c_client *client,
if ((ret < 0) || (ret >= ST_ACCEL_MAX)) if ((ret < 0) || (ret >= ST_ACCEL_MAX))
return -ENODEV; return -ENODEV;
strncpy(client->name, st_accel_id_table[ret].name, strlcpy(client->name, st_accel_id_table[ret].name,
sizeof(client->name)); sizeof(client->name));
client->name[sizeof(client->name) - 1] = '\0';
} else if (!id) } else if (!id)
return -ENODEV; return -ENODEV;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment