Commit cc66b6fc authored by Andrew Morton's avatar Andrew Morton Committed by Linus Torvalds

[PATCH] remove bogus MOD_{INC,DEC}_USE_COUNT from hysdn

From: Christoph Hellwig <hch@lst.de>

the maintainer doesn't response unfortauntely, but removing these from
net_devices unconditionally is the 2.6 way to go, there's no more module
refcounting on net devices.
parent 36bf1087
...@@ -53,8 +53,6 @@ struct net_local { ...@@ -53,8 +53,6 @@ struct net_local {
struct sk_buff *skbs[MAX_SKB_BUFFERS]; /* pointers to tx-skbs */ struct sk_buff *skbs[MAX_SKB_BUFFERS]; /* pointers to tx-skbs */
int in_idx, out_idx; /* indexes to buffer ring */ int in_idx, out_idx; /* indexes to buffer ring */
int sk_count; /* number of buffers currently in ring */ int sk_count; /* number of buffers currently in ring */
int is_open; /* flag controlling module locking */
}; /* net_local */ }; /* net_local */
...@@ -82,10 +80,6 @@ net_open(struct net_device *dev) ...@@ -82,10 +80,6 @@ net_open(struct net_device *dev)
hysdn_card *card = dev->priv; hysdn_card *card = dev->priv;
int i; int i;
if (!((struct net_local *) dev)->is_open)
MOD_INC_USE_COUNT; /* increment only if interface is actually down */
((struct net_local *) dev)->is_open = 1; /* device actually open */
netif_start_queue(dev); /* start tx-queueing */ netif_start_queue(dev); /* start tx-queueing */
/* Fill in the MAC-level header (if not already set) */ /* Fill in the MAC-level header (if not already set) */
...@@ -130,9 +124,6 @@ net_close(struct net_device *dev) ...@@ -130,9 +124,6 @@ net_close(struct net_device *dev)
netif_stop_queue(dev); /* disable queueing */ netif_stop_queue(dev); /* disable queueing */
if (((struct net_local *) dev)->is_open)
MOD_DEC_USE_COUNT; /* adjust module counter */
((struct net_local *) dev)->is_open = 0;
flush_tx_buffers((struct net_local *) dev); flush_tx_buffers((struct net_local *) dev);
return (0); /* success */ return (0); /* success */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment