Commit cd05c155 authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen

scsi: lpfc: Annotate switch/case fall-through

This patch avoids that the compiler warns about missing fall-through
annotation when building with W=1.

Cc: James Smart <james.smart@broadcom.com>
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Acked-by: default avatarJames Smart <james.smart@broadcom.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent ffd43814
...@@ -3099,6 +3099,7 @@ lpfc_fdmi_cmd(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp, ...@@ -3099,6 +3099,7 @@ lpfc_fdmi_cmd(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp,
case SLI_MGMT_GHAT: case SLI_MGMT_GHAT:
case SLI_MGMT_GRPL: case SLI_MGMT_GRPL:
rsp_size = FC_MAX_NS_RSP; rsp_size = FC_MAX_NS_RSP;
/* fall through */
case SLI_MGMT_DHBA: case SLI_MGMT_DHBA:
case SLI_MGMT_DHAT: case SLI_MGMT_DHAT:
pe = (struct lpfc_fdmi_port_entry *)&CtReq->un.PortID; pe = (struct lpfc_fdmi_port_entry *)&CtReq->un.PortID;
...@@ -3111,6 +3112,7 @@ lpfc_fdmi_cmd(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp, ...@@ -3111,6 +3112,7 @@ lpfc_fdmi_cmd(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp,
case SLI_MGMT_GPAT: case SLI_MGMT_GPAT:
case SLI_MGMT_GPAS: case SLI_MGMT_GPAS:
rsp_size = FC_MAX_NS_RSP; rsp_size = FC_MAX_NS_RSP;
/* fall through */
case SLI_MGMT_DPRT: case SLI_MGMT_DPRT:
case SLI_MGMT_DPA: case SLI_MGMT_DPA:
pe = (struct lpfc_fdmi_port_entry *)&CtReq->un.PortID; pe = (struct lpfc_fdmi_port_entry *)&CtReq->un.PortID;
......
...@@ -8775,7 +8775,7 @@ lpfc_cmpl_reg_new_vport(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb) ...@@ -8775,7 +8775,7 @@ lpfc_cmpl_reg_new_vport(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb)
lpfc_nlp_put(ndlp); lpfc_nlp_put(ndlp);
return; return;
} }
/* fall through */
default: default:
/* Try to recover from this error */ /* Try to recover from this error */
if (phba->sli_rev == LPFC_SLI_REV4) if (phba->sli_rev == LPFC_SLI_REV4)
......
...@@ -4666,12 +4666,15 @@ lpfc_check_sli_ndlp(struct lpfc_hba *phba, ...@@ -4666,12 +4666,15 @@ lpfc_check_sli_ndlp(struct lpfc_hba *phba,
case CMD_GEN_REQUEST64_CR: case CMD_GEN_REQUEST64_CR:
if (iocb->context_un.ndlp == ndlp) if (iocb->context_un.ndlp == ndlp)
return 1; return 1;
/* fall through */
case CMD_ELS_REQUEST64_CR: case CMD_ELS_REQUEST64_CR:
if (icmd->un.elsreq64.remoteID == ndlp->nlp_DID) if (icmd->un.elsreq64.remoteID == ndlp->nlp_DID)
return 1; return 1;
/* fall through */
case CMD_XMIT_ELS_RSP64_CX: case CMD_XMIT_ELS_RSP64_CX:
if (iocb->context1 == (uint8_t *) ndlp) if (iocb->context1 == (uint8_t *) ndlp)
return 1; return 1;
/* fall through */
} }
} else if (pring->ringno == LPFC_FCP_RING) { } else if (pring->ringno == LPFC_FCP_RING) {
/* Skip match check if waiting to relogin to FCP target */ /* Skip match check if waiting to relogin to FCP target */
...@@ -5863,7 +5866,7 @@ lpfc_disc_timeout_handler(struct lpfc_vport *vport) ...@@ -5863,7 +5866,7 @@ lpfc_disc_timeout_handler(struct lpfc_vport *vport)
case LPFC_LINK_UP: case LPFC_LINK_UP:
lpfc_issue_clear_la(phba, vport); lpfc_issue_clear_la(phba, vport);
/* Drop thru */ /* fall through */
case LPFC_LINK_UNKNOWN: case LPFC_LINK_UNKNOWN:
case LPFC_WARM_START: case LPFC_WARM_START:
case LPFC_INIT_START: case LPFC_INIT_START:
......
...@@ -360,6 +360,7 @@ lpfc_rcv_plogi(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp, ...@@ -360,6 +360,7 @@ lpfc_rcv_plogi(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp,
case NLP_STE_NPR_NODE: case NLP_STE_NPR_NODE:
if (!(ndlp->nlp_flag & NLP_NPR_ADISC)) if (!(ndlp->nlp_flag & NLP_NPR_ADISC))
break; break;
/* fall through */
case NLP_STE_REG_LOGIN_ISSUE: case NLP_STE_REG_LOGIN_ISSUE:
case NLP_STE_PRLI_ISSUE: case NLP_STE_PRLI_ISSUE:
case NLP_STE_UNMAPPED_NODE: case NLP_STE_UNMAPPED_NODE:
......
...@@ -1106,6 +1106,7 @@ lpfc_nvme_io_cmd_wqe_cmpl(struct lpfc_hba *phba, struct lpfc_iocbq *pwqeIn, ...@@ -1106,6 +1106,7 @@ lpfc_nvme_io_cmd_wqe_cmpl(struct lpfc_hba *phba, struct lpfc_iocbq *pwqeIn,
lpfc_ncmd, nCmd, lpfc_ncmd, nCmd,
lpfc_ncmd->cur_iocbq.sli4_xritag, lpfc_ncmd->cur_iocbq.sli4_xritag,
bf_get(lpfc_wcqe_c_xb, wcqe)); bf_get(lpfc_wcqe_c_xb, wcqe));
/* fall through */
default: default:
out_err: out_err:
lpfc_printf_vlog(vport, KERN_INFO, LOG_NVME_IOERR, lpfc_printf_vlog(vport, KERN_INFO, LOG_NVME_IOERR,
......
...@@ -1137,7 +1137,7 @@ lpfc_bg_err_inject(struct lpfc_hba *phba, struct scsi_cmnd *sc, ...@@ -1137,7 +1137,7 @@ lpfc_bg_err_inject(struct lpfc_hba *phba, struct scsi_cmnd *sc,
break; break;
} }
/* Drop thru */ /* fall through */
case SCSI_PROT_WRITE_INSERT: case SCSI_PROT_WRITE_INSERT:
/* /*
* For WRITE_INSERT, force the error * For WRITE_INSERT, force the error
...@@ -1256,7 +1256,7 @@ lpfc_bg_err_inject(struct lpfc_hba *phba, struct scsi_cmnd *sc, ...@@ -1256,7 +1256,7 @@ lpfc_bg_err_inject(struct lpfc_hba *phba, struct scsi_cmnd *sc,
rc = BG_ERR_TGT | BG_ERR_CHECK; rc = BG_ERR_TGT | BG_ERR_CHECK;
break; break;
} }
/* Drop thru */ /* fall through */
case SCSI_PROT_WRITE_INSERT: case SCSI_PROT_WRITE_INSERT:
/* /*
* For WRITE_INSERT, force the * For WRITE_INSERT, force the
...@@ -1338,7 +1338,7 @@ lpfc_bg_err_inject(struct lpfc_hba *phba, struct scsi_cmnd *sc, ...@@ -1338,7 +1338,7 @@ lpfc_bg_err_inject(struct lpfc_hba *phba, struct scsi_cmnd *sc,
switch (op) { switch (op) {
case SCSI_PROT_WRITE_PASS: case SCSI_PROT_WRITE_PASS:
rc = BG_ERR_CHECK; rc = BG_ERR_CHECK;
/* Drop thru */ /* fall through */
case SCSI_PROT_WRITE_INSERT: case SCSI_PROT_WRITE_INSERT:
/* /*
...@@ -3822,7 +3822,7 @@ lpfc_scsi_cmd_iocb_cmpl(struct lpfc_hba *phba, struct lpfc_iocbq *pIocbIn, ...@@ -3822,7 +3822,7 @@ lpfc_scsi_cmd_iocb_cmpl(struct lpfc_hba *phba, struct lpfc_iocbq *pIocbIn,
lpfc_cmd->cur_iocbq.sli4_lxritag, lpfc_cmd->cur_iocbq.sli4_lxritag,
0, 0); 0, 0);
} }
/* else: fall through */ /* fall through */
default: default:
cmd->result = DID_ERROR << 16; cmd->result = DID_ERROR << 16;
break; break;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment