Commit cdf6adb2 authored by Shaoyun Liu's avatar Shaoyun Liu Committed by Alex Deucher

drm/amdgpu: Move kiq ring lock out of virt structure

The usage of kiq should not depend on the virtualization.
Signed-off-by: default avatarShaoyun Liu <Shaoyun.Liu@amd.com>
Reviewed-by: default avatarAndres Rodriquez <andresx7@gmail.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent b98b8dbc
...@@ -907,6 +907,7 @@ struct amdgpu_mec { ...@@ -907,6 +907,7 @@ struct amdgpu_mec {
struct amdgpu_kiq { struct amdgpu_kiq {
u64 eop_gpu_addr; u64 eop_gpu_addr;
struct amdgpu_bo *eop_obj; struct amdgpu_bo *eop_obj;
struct mutex ring_mutex;
struct amdgpu_ring ring; struct amdgpu_ring ring;
struct amdgpu_irq_src irq; struct amdgpu_irq_src irq;
}; };
......
...@@ -108,7 +108,6 @@ void amdgpu_virt_init_setting(struct amdgpu_device *adev) ...@@ -108,7 +108,6 @@ void amdgpu_virt_init_setting(struct amdgpu_device *adev)
adev->cg_flags = 0; adev->cg_flags = 0;
adev->pg_flags = 0; adev->pg_flags = 0;
mutex_init(&adev->virt.lock_kiq);
mutex_init(&adev->virt.lock_reset); mutex_init(&adev->virt.lock_reset);
} }
...@@ -122,12 +121,12 @@ uint32_t amdgpu_virt_kiq_rreg(struct amdgpu_device *adev, uint32_t reg) ...@@ -122,12 +121,12 @@ uint32_t amdgpu_virt_kiq_rreg(struct amdgpu_device *adev, uint32_t reg)
BUG_ON(!ring->funcs->emit_rreg); BUG_ON(!ring->funcs->emit_rreg);
mutex_lock(&adev->virt.lock_kiq); mutex_lock(&kiq->ring_mutex);
amdgpu_ring_alloc(ring, 32); amdgpu_ring_alloc(ring, 32);
amdgpu_ring_emit_rreg(ring, reg); amdgpu_ring_emit_rreg(ring, reg);
amdgpu_fence_emit(ring, &f); amdgpu_fence_emit(ring, &f);
amdgpu_ring_commit(ring); amdgpu_ring_commit(ring);
mutex_unlock(&adev->virt.lock_kiq); mutex_unlock(&kiq->ring_mutex);
r = dma_fence_wait(f, false); r = dma_fence_wait(f, false);
if (r) if (r)
...@@ -148,12 +147,12 @@ void amdgpu_virt_kiq_wreg(struct amdgpu_device *adev, uint32_t reg, uint32_t v) ...@@ -148,12 +147,12 @@ void amdgpu_virt_kiq_wreg(struct amdgpu_device *adev, uint32_t reg, uint32_t v)
BUG_ON(!ring->funcs->emit_wreg); BUG_ON(!ring->funcs->emit_wreg);
mutex_lock(&adev->virt.lock_kiq); mutex_lock(&kiq->ring_mutex);
amdgpu_ring_alloc(ring, 32); amdgpu_ring_alloc(ring, 32);
amdgpu_ring_emit_wreg(ring, reg, v); amdgpu_ring_emit_wreg(ring, reg, v);
amdgpu_fence_emit(ring, &f); amdgpu_fence_emit(ring, &f);
amdgpu_ring_commit(ring); amdgpu_ring_commit(ring);
mutex_unlock(&adev->virt.lock_kiq); mutex_unlock(&kiq->ring_mutex);
r = dma_fence_wait(f, false); r = dma_fence_wait(f, false);
if (r) if (r)
......
...@@ -52,7 +52,6 @@ struct amdgpu_virt { ...@@ -52,7 +52,6 @@ struct amdgpu_virt {
uint64_t csa_vmid0_addr; uint64_t csa_vmid0_addr;
bool chained_ib_support; bool chained_ib_support;
uint32_t reg_val_offs; uint32_t reg_val_offs;
struct mutex lock_kiq;
struct mutex lock_reset; struct mutex lock_reset;
struct amdgpu_irq_src ack_irq; struct amdgpu_irq_src ack_irq;
struct amdgpu_irq_src rcv_irq; struct amdgpu_irq_src rcv_irq;
......
...@@ -1385,6 +1385,8 @@ static int gfx_v8_0_kiq_init_ring(struct amdgpu_device *adev, ...@@ -1385,6 +1385,8 @@ static int gfx_v8_0_kiq_init_ring(struct amdgpu_device *adev,
struct amdgpu_kiq *kiq = &adev->gfx.kiq; struct amdgpu_kiq *kiq = &adev->gfx.kiq;
int r = 0; int r = 0;
mutex_init(&kiq->ring_mutex);
r = amdgpu_wb_get(adev, &adev->virt.reg_val_offs); r = amdgpu_wb_get(adev, &adev->virt.reg_val_offs);
if (r) if (r)
return r; return r;
......
...@@ -614,6 +614,8 @@ static int gfx_v9_0_kiq_init_ring(struct amdgpu_device *adev, ...@@ -614,6 +614,8 @@ static int gfx_v9_0_kiq_init_ring(struct amdgpu_device *adev,
struct amdgpu_kiq *kiq = &adev->gfx.kiq; struct amdgpu_kiq *kiq = &adev->gfx.kiq;
int r = 0; int r = 0;
mutex_init(&kiq->ring_mutex);
r = amdgpu_wb_get(adev, &adev->virt.reg_val_offs); r = amdgpu_wb_get(adev, &adev->virt.reg_val_offs);
if (r) if (r)
return r; return r;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment