Commit ce0b89f3 authored by Dan Williams's avatar Dan Williams

isci: task.h compile and checkpatch fixes

A usage of "FALSE" leaked in as well as some checkpatch escapes.
Signed-off-by: default avatarDan Williams <dan.j.williams@intel.com>
parent c4b9e24c
...@@ -306,7 +306,6 @@ isci_task_set_completion_status( ...@@ -306,7 +306,6 @@ isci_task_set_completion_status(
* is in the error path. * is in the error path.
*/ */
if (task->task_state_flags & SAS_TASK_NEED_DEV_RESET) { if (task->task_state_flags & SAS_TASK_NEED_DEV_RESET) {
/* Fail the I/O to make sure it goes into the error path. */ /* Fail the I/O to make sure it goes into the error path. */
response = SAS_TASK_UNDELIVERED; response = SAS_TASK_UNDELIVERED;
status = SAM_STAT_TASK_ABORTED; status = SAM_STAT_TASK_ABORTED;
...@@ -317,22 +316,19 @@ isci_task_set_completion_status( ...@@ -317,22 +316,19 @@ isci_task_set_completion_status(
task->task_status.stat = status; task->task_status.stat = status;
switch (task_notification_selection) { switch (task_notification_selection) {
case isci_perform_aborted_io_completion: case isci_perform_aborted_io_completion:
/* This path can occur with task-managed requests as well as /* This path can occur with task-managed requests as well as
* requests terminated because of LUN or device resets. * requests terminated because of LUN or device resets.
*/ */
/* Fall through to the normal case... */ /* Fall through to the normal case... */
case isci_perform_normal_io_completion: case isci_perform_normal_io_completion:
/* Normal notification (task_done) */ /* Normal notification (task_done) */
isci_set_task_doneflags(task); isci_set_task_doneflags(task);
break; break;
default: default:
WARN_ON(FALSE); WARN_ONCE(1, "unknown task_notification_selection: %d\n",
task_notification_selection);
/* Fall through to the error case... */ /* Fall through to the error case... */
case isci_perform_error_io_completion: case isci_perform_error_io_completion:
/* Use sas_task_abort */ /* Use sas_task_abort */
/* Leave SAS_TASK_STATE_DONE clear /* Leave SAS_TASK_STATE_DONE clear
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment