Commit ce6c1cd2 authored by Dan Carpenter's avatar Dan Carpenter Committed by Linus Walleij

pinctrl: nsp-gpio: forever loop in nsp_gpio_get_strength()

There is a signedness bug here so the loop will never exit.

Fixes: 8bfcbbbc ('pinctrl: nsp: add gpio-a driver support for Broadcom NSP SoC')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent a898c835
...@@ -439,9 +439,10 @@ static int nsp_gpio_set_strength(struct nsp_gpio *chip, unsigned gpio, ...@@ -439,9 +439,10 @@ static int nsp_gpio_set_strength(struct nsp_gpio *chip, unsigned gpio,
static int nsp_gpio_get_strength(struct nsp_gpio *chip, unsigned gpio, static int nsp_gpio_get_strength(struct nsp_gpio *chip, unsigned gpio,
u16 *strength) u16 *strength)
{ {
unsigned int i, offset, shift; unsigned int offset, shift;
u32 val; u32 val;
unsigned long flags; unsigned long flags;
int i;
offset = NSP_GPIO_DRV_CTRL; offset = NSP_GPIO_DRV_CTRL;
shift = gpio; shift = gpio;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment