Commit ce8273a5 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Frederic Weisbecker

smbfs: Push down BKL into ioctl function

Converting from ->ioctl to ->unlocked_ioctl with explicit
lock_kernel lets us kill the ioctl operation.
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
[fixed inode reference in smb_ioctl]
Signed-off-by: default avatarFrederic Weisbecker <fweisbec@gmail.com>
parent 97718390
...@@ -39,7 +39,7 @@ const struct file_operations smb_dir_operations = ...@@ -39,7 +39,7 @@ const struct file_operations smb_dir_operations =
{ {
.read = generic_read_dir, .read = generic_read_dir,
.readdir = smb_readdir, .readdir = smb_readdir,
.ioctl = smb_ioctl, .unlocked_ioctl = smb_ioctl,
.open = smb_dir_open, .open = smb_dir_open,
}; };
......
...@@ -437,7 +437,7 @@ const struct file_operations smb_file_operations = ...@@ -437,7 +437,7 @@ const struct file_operations smb_file_operations =
.aio_read = smb_file_aio_read, .aio_read = smb_file_aio_read,
.write = do_sync_write, .write = do_sync_write,
.aio_write = smb_file_aio_write, .aio_write = smb_file_aio_write,
.ioctl = smb_ioctl, .unlocked_ioctl = smb_ioctl,
.mmap = smb_file_mmap, .mmap = smb_file_mmap,
.open = smb_file_open, .open = smb_file_open,
.release = smb_file_release, .release = smb_file_release,
......
...@@ -13,6 +13,7 @@ ...@@ -13,6 +13,7 @@
#include <linux/time.h> #include <linux/time.h>
#include <linux/mm.h> #include <linux/mm.h>
#include <linux/highuid.h> #include <linux/highuid.h>
#include <linux/smp_lock.h>
#include <linux/net.h> #include <linux/net.h>
#include <linux/smb_fs.h> #include <linux/smb_fs.h>
...@@ -22,14 +23,14 @@ ...@@ -22,14 +23,14 @@
#include "proto.h" #include "proto.h"
int long
smb_ioctl(struct inode *inode, struct file *filp, smb_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
unsigned int cmd, unsigned long arg)
{ {
struct smb_sb_info *server = server_from_inode(inode); struct smb_sb_info *server = server_from_inode(filp->f_path.dentry->d_inode);
struct smb_conn_opt opt; struct smb_conn_opt opt;
int result = -EINVAL; int result = -EINVAL;
lock_kernel();
switch (cmd) { switch (cmd) {
uid16_t uid16; uid16_t uid16;
uid_t uid32; uid_t uid32;
...@@ -62,6 +63,7 @@ smb_ioctl(struct inode *inode, struct file *filp, ...@@ -62,6 +63,7 @@ smb_ioctl(struct inode *inode, struct file *filp,
default: default:
break; break;
} }
unlock_kernel();
return result; return result;
} }
...@@ -67,7 +67,7 @@ extern const struct address_space_operations smb_file_aops; ...@@ -67,7 +67,7 @@ extern const struct address_space_operations smb_file_aops;
extern const struct file_operations smb_file_operations; extern const struct file_operations smb_file_operations;
extern const struct inode_operations smb_file_inode_operations; extern const struct inode_operations smb_file_inode_operations;
/* ioctl.c */ /* ioctl.c */
extern int smb_ioctl(struct inode *inode, struct file *filp, unsigned int cmd, unsigned long arg); extern long smb_ioctl(struct file *filp, unsigned int cmd, unsigned long arg);
/* smbiod.c */ /* smbiod.c */
extern void smbiod_wake_up(void); extern void smbiod_wake_up(void);
extern int smbiod_register_server(struct smb_sb_info *server); extern int smbiod_register_server(struct smb_sb_info *server);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment