Commit cf36dd2f authored by Nishka Dasgupta's avatar Nishka Dasgupta Committed by David S. Miller

net: ethernet: mediatek: mtk_eth_soc: Add of_node_put() before goto

Each iteration of for_each_child_of_node puts the previous node, but in
the case of a goto from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the goto.
Issue found with Coccinelle.
Signed-off-by: default avatarNishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 64fc973d
...@@ -2548,9 +2548,11 @@ static int mtk_probe(struct platform_device *pdev) ...@@ -2548,9 +2548,11 @@ static int mtk_probe(struct platform_device *pdev)
continue; continue;
err = mtk_add_mac(eth, mac_np); err = mtk_add_mac(eth, mac_np);
if (err) if (err) {
of_node_put(mac_np);
goto err_deinit_hw; goto err_deinit_hw;
} }
}
if (MTK_HAS_CAPS(eth->soc->caps, MTK_SHARED_INT)) { if (MTK_HAS_CAPS(eth->soc->caps, MTK_SHARED_INT)) {
err = devm_request_irq(eth->dev, eth->irq[0], err = devm_request_irq(eth->dev, eth->irq[0],
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment