Commit cf3b576d authored by Dan Carpenter's avatar Dan Carpenter Committed by Mauro Carvalho Chehab

[media] dvb: si21xx: buffer overflow in si21_writeregs()

"len" is user controlled and can be up to 255.  Anything more than 59
will cause a buffer overflow so we need to add a test for that.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent e947d9ad
...@@ -236,6 +236,9 @@ static int si21_writeregs(struct si21xx_state *state, u8 reg1, ...@@ -236,6 +236,9 @@ static int si21_writeregs(struct si21xx_state *state, u8 reg1,
.len = len + 1 .len = len + 1
}; };
if (len > sizeof(buf) - 1)
return -EINVAL;
msg.buf[0] = reg1; msg.buf[0] = reg1;
memcpy(msg.buf + 1, data, len); memcpy(msg.buf + 1, data, len);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment