Commit d29f6c19 authored by Todd Poynor's avatar Todd Poynor Committed by Greg Kroah-Hartman

Revert "staging: gasket: page table: hold references to device and pci_dev"

gasket_free_dev() is called only from driver PCI probe and remove
function. It is guaranteed that that pci_dev structure is not going
anywhere during that time; there is no need to take this additional
reference.

This reverts commit dd9d1502.
Reported-by: default avatarDmitry Torokhov <dtor@chromium.org>
Signed-off-by: default avatarTodd Poynor <toddpoynor@google.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e02fed16
...@@ -280,7 +280,7 @@ int gasket_page_table_init(struct gasket_page_table **ppg_tbl, ...@@ -280,7 +280,7 @@ int gasket_page_table_init(struct gasket_page_table **ppg_tbl,
pg_tbl->extended_offset_reg = pg_tbl->extended_offset_reg =
(u64 __iomem *)&bar_data->virt_base[page_table_config->extended_reg]; (u64 __iomem *)&bar_data->virt_base[page_table_config->extended_reg];
pg_tbl->device = get_device(device); pg_tbl->device = get_device(device);
pg_tbl->pci_dev = pci_dev_get(pci_dev); pg_tbl->pci_dev = pci_dev;
dev_dbg(device, "Page table initialized successfully\n"); dev_dbg(device, "Page table initialized successfully\n");
...@@ -378,7 +378,6 @@ void gasket_page_table_cleanup(struct gasket_page_table *pg_tbl) ...@@ -378,7 +378,6 @@ void gasket_page_table_cleanup(struct gasket_page_table *pg_tbl)
pg_tbl->entries = NULL; pg_tbl->entries = NULL;
put_device(pg_tbl->device); put_device(pg_tbl->device);
pci_dev_put(pg_tbl->pci_dev);
kfree(pg_tbl); kfree(pg_tbl);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment