Commit d2c32258 authored by Josh Triplett's avatar Josh Triplett Committed by Linus Torvalds

gcov: disable CONFIG_CONSTRUCTORS when not needed by CONFIG_GCOV_KERNEL

CONFIG_CONSTRUCTORS controls support for running constructor functions at
kernel init time.  According to commit b99b87f7 ("kernel:
constructor support"), gcov (CONFIG_GCOV_KERNEL) needs this.  However,
CONFIG_CONSTRUCTORS currently defaults to y, with no option to disable it,
and CONFIG_GCOV_KERNEL depends on it.  Instead, default it to n and have
CONFIG_GCOV_KERNEL select it, so that the normal case of
CONFIG_GCOV_KERNEL=n will result in CONFIG_CONSTRUCTORS=n.

Observed in the short list of =y values in a minimal kernel configuration.
Signed-off-by: default avatarJosh Triplett <josh@joshtriplett.org>
Acked-by: default avatarWANG Cong <xiyou.wangcong@gmail.com>
Acked-by: default avatarPeter Oberparleiter <peter.oberparleiter@de.ibm.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent b0461a44
...@@ -19,7 +19,6 @@ config DEFCONFIG_LIST ...@@ -19,7 +19,6 @@ config DEFCONFIG_LIST
config CONSTRUCTORS config CONSTRUCTORS
bool bool
depends on !UML depends on !UML
default y
config HAVE_IRQ_WORK config HAVE_IRQ_WORK
bool bool
......
...@@ -2,7 +2,8 @@ menu "GCOV-based kernel profiling" ...@@ -2,7 +2,8 @@ menu "GCOV-based kernel profiling"
config GCOV_KERNEL config GCOV_KERNEL
bool "Enable gcov-based kernel profiling" bool "Enable gcov-based kernel profiling"
depends on DEBUG_FS && CONSTRUCTORS depends on DEBUG_FS
select CONSTRUCTORS
default n default n
---help--- ---help---
This option enables gcov-based code profiling (e.g. for code coverage This option enables gcov-based code profiling (e.g. for code coverage
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment