Commit d48abfec authored by Harvey Harrison's avatar Harvey Harrison Committed by David S. Miller

net: em_cmp.c use unaligned access helpers

Signed-off-by: default avatarHarvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 978e9aec
...@@ -14,6 +14,7 @@ ...@@ -14,6 +14,7 @@
#include <linux/kernel.h> #include <linux/kernel.h>
#include <linux/skbuff.h> #include <linux/skbuff.h>
#include <linux/tc_ematch/tc_em_cmp.h> #include <linux/tc_ematch/tc_em_cmp.h>
#include <asm/unaligned.h>
#include <net/pkt_cls.h> #include <net/pkt_cls.h>
static inline int cmp_needs_transformation(struct tcf_em_cmp *cmp) static inline int cmp_needs_transformation(struct tcf_em_cmp *cmp)
...@@ -37,8 +38,7 @@ static int em_cmp_match(struct sk_buff *skb, struct tcf_ematch *em, ...@@ -37,8 +38,7 @@ static int em_cmp_match(struct sk_buff *skb, struct tcf_ematch *em,
break; break;
case TCF_EM_ALIGN_U16: case TCF_EM_ALIGN_U16:
val = *ptr << 8; val = get_unaligned_be16(ptr);
val |= *(ptr+1);
if (cmp_needs_transformation(cmp)) if (cmp_needs_transformation(cmp))
val = be16_to_cpu(val); val = be16_to_cpu(val);
...@@ -47,10 +47,7 @@ static int em_cmp_match(struct sk_buff *skb, struct tcf_ematch *em, ...@@ -47,10 +47,7 @@ static int em_cmp_match(struct sk_buff *skb, struct tcf_ematch *em,
case TCF_EM_ALIGN_U32: case TCF_EM_ALIGN_U32:
/* Worth checking boundries? The branching seems /* Worth checking boundries? The branching seems
* to get worse. Visit again. */ * to get worse. Visit again. */
val = *ptr << 24; val = get_unaligned_be32(ptr);
val |= *(ptr+1) << 16;
val |= *(ptr+2) << 8;
val |= *(ptr+3);
if (cmp_needs_transformation(cmp)) if (cmp_needs_transformation(cmp))
val = be32_to_cpu(val); val = be32_to_cpu(val);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment