Commit d553ad86 authored by Rusty Russell's avatar Rusty Russell

param: fix NULL comparison on oom

kp->arg is always true: it's the contents of that pointer we care about.
Reported-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
Cc: stable@kernel.org
parent 65afac7d
...@@ -222,7 +222,7 @@ int param_set_charp(const char *val, struct kernel_param *kp) ...@@ -222,7 +222,7 @@ int param_set_charp(const char *val, struct kernel_param *kp)
* don't need to; this mangled commandline is preserved. */ * don't need to; this mangled commandline is preserved. */
if (slab_is_available()) { if (slab_is_available()) {
*(char **)kp->arg = kstrdup(val, GFP_KERNEL); *(char **)kp->arg = kstrdup(val, GFP_KERNEL);
if (!kp->arg) if (!*(char **)kp->arg)
return -ENOMEM; return -ENOMEM;
} else } else
*(const char **)kp->arg = val; *(const char **)kp->arg = val;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment