Commit d57019d1 authored by Sergei Shtylyov's avatar Sergei Shtylyov Committed by David S. Miller

at803x: fix reset handling

The driver of course "knows" that the chip's reset signal is active low,
so  it drives the GPIO to 0  to reset the PHY and to 1 otherwise; however
all this will only work iff the GPIO  is  specified as active-high in the
device tree!  I think both the driver and the device trees (if there are
any -- I was unable to find them) need to be fixed in this case...

Fixes: 13a56b44 ("net: phy: at803x: Add support for hardware reset")
Signed-off-by: default avatarSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Acked-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9a349219
...@@ -277,7 +277,7 @@ static int at803x_probe(struct phy_device *phydev) ...@@ -277,7 +277,7 @@ static int at803x_probe(struct phy_device *phydev)
if (!priv) if (!priv)
return -ENOMEM; return -ENOMEM;
gpiod_reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); gpiod_reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);
if (IS_ERR(gpiod_reset)) if (IS_ERR(gpiod_reset))
return PTR_ERR(gpiod_reset); return PTR_ERR(gpiod_reset);
...@@ -362,10 +362,10 @@ static void at803x_link_change_notify(struct phy_device *phydev) ...@@ -362,10 +362,10 @@ static void at803x_link_change_notify(struct phy_device *phydev)
at803x_context_save(phydev, &context); at803x_context_save(phydev, &context);
gpiod_set_value(priv->gpiod_reset, 0);
msleep(1);
gpiod_set_value(priv->gpiod_reset, 1); gpiod_set_value(priv->gpiod_reset, 1);
msleep(1); msleep(1);
gpiod_set_value(priv->gpiod_reset, 0);
msleep(1);
at803x_context_restore(phydev, &context); at803x_context_restore(phydev, &context);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment