Commit d5eda75f authored by Andy Whitcroft's avatar Andy Whitcroft Committed by Michal Marek

kbuild: fix LOCALVERSION handling to match description

In the commit below the version string handling was modified, adding
a '+' where no other version information was supplied:

    commit 85a256d8
    Author: David Rientjes <rientjes@google.com>
    Date:   Wed Jan 13 13:01:05 2010 -0800

From the commit the intent was as below:

     - when CONFIG_LOCALVERSION_AUTO is disabled, a `+' is appended if the
       repository has been revised beyond a tagged commit and LOCALVERSION=
       was not passed to "make".

However if the user supplies an empty LOCALVERSION on the command line
the plus suffix is still added.  This form is useful in the case where
the build environment knows that the version as specified is correct and
complete but does not correspond to a specific tag.

This patch changes the implementation to match the documentation
such that specifying LOCALVERSION= on the build line is sufficient
to suppress any suffix.
Signed-off-by: default avatarAndy Whitcroft <apw@canonical.com>
Acked-by: default avatarDavid Rientjes <rientjes@google.com>
Signed-off-by: default avatarMichal Marek <mmarek@suse.cz>
parent 1c938663
...@@ -944,7 +944,7 @@ ifdef CONFIG_LOCALVERSION_AUTO ...@@ -944,7 +944,7 @@ ifdef CONFIG_LOCALVERSION_AUTO
localver-extra = $(scm-identifier) localver-extra = $(scm-identifier)
else else
ifneq ($(scm-identifier),) ifneq ($(scm-identifier),)
ifeq ($(LOCALVERSION),) ifeq ("$(origin LOCALVERSION)", "undefined")
localver-extra = + localver-extra = +
endif endif
endif endif
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment