Commit d7587b14 authored by Paul Mundt's avatar Paul Mundt

sh: Force __access_ok() to obey address space limit.

When the thread_info->addr_limit changes were introduced, __access_ok()
was missed in the conversion, allowing user processes to perform P1/P2
accesses under certain conditions.

This has already been corrected with the nommu refactoring in later
kernels.
Signed-off-by: default avatarPaul Mundt <lethal@linux-sh.org>
parent 844b43ad
...@@ -73,38 +73,26 @@ static inline int __access_ok(unsigned long addr, unsigned long size) ...@@ -73,38 +73,26 @@ static inline int __access_ok(unsigned long addr, unsigned long size)
/* /*
* __access_ok: Check if address with size is OK or not. * __access_ok: Check if address with size is OK or not.
* *
* We do three checks: * Uhhuh, this needs 33-bit arithmetic. We have a carry..
* (1) is it user space?
* (2) addr + size --> carry?
* (3) addr + size >= 0x80000000 (PAGE_OFFSET)
* *
* (1) (2) (3) | RESULT * sum := addr + size; carry? --> flag = true;
* 0 0 0 | ok * if (sum >= addr_limit) flag = true;
* 0 0 1 | ok
* 0 1 0 | bad
* 0 1 1 | bad
* 1 0 0 | ok
* 1 0 1 | bad
* 1 1 0 | bad
* 1 1 1 | bad
*/ */
static inline int __access_ok(unsigned long addr, unsigned long size) static inline int __access_ok(unsigned long addr, unsigned long size)
{ {
unsigned long flag, tmp; unsigned long flag, sum;
__asm__("stc r7_bank, %0\n\t" __asm__("clrt\n\t"
"mov.l @(8,%0), %0\n\t" "addc %3, %1\n\t"
"clrt\n\t" "movt %0\n\t"
"addc %2, %1\n\t" "cmp/hi %4, %1\n\t"
"and %1, %0\n\t" "rotcl %0"
"rotcl %0\n\t" :"=&r" (flag), "=r" (sum)
"rotcl %0\n\t" :"1" (addr), "r" (size),
"and #3, %0" "r" (current_thread_info()->addr_limit.seg)
: "=&z" (flag), "=r" (tmp) :"t");
: "r" (addr), "1" (size)
: "t");
return flag == 0; return flag == 0;
} }
#endif /* CONFIG_MMU */ #endif /* CONFIG_MMU */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment