Commit d7b686eb authored by Linus Torvalds's avatar Linus Torvalds

Merge branch 'i2c/for-current' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux

Pull i2c fixes from Wolfram Sang:

 - bugfixes for uniphier, i801, and xiic drivers

 - ID removal (never produced) for imx

 - one MAINTAINER addition

* 'i2c/for-current' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux:
  i2c: xiic: Record xilinx i2c with Zynq fragment
  i2c: xiic: Make the start and the byte count write atomic
  i2c: i801: fix DNV's SMBCTRL register offset
  i2c: imx-lpi2c: Remove mx8dv compatible entry
  dt-bindings: imx-lpi2c: Remove mx8dv compatible entry
  i2c: uniphier-f: issue STOP only for last message or I2C_M_STOP
  i2c: uniphier: issue STOP only for last message or I2C_M_STOP
parents 2c34a0e0 da4dfaf8
...@@ -3,7 +3,6 @@ ...@@ -3,7 +3,6 @@
Required properties: Required properties:
- compatible : - compatible :
- "fsl,imx7ulp-lpi2c" for LPI2C compatible with the one integrated on i.MX7ULP soc - "fsl,imx7ulp-lpi2c" for LPI2C compatible with the one integrated on i.MX7ULP soc
- "fsl,imx8dv-lpi2c" for LPI2C compatible with the one integrated on i.MX8DV soc
- reg : address and length of the lpi2c master registers - reg : address and length of the lpi2c master registers
- interrupts : lpi2c interrupt - interrupts : lpi2c interrupt
- clocks : lpi2c clock specifier - clocks : lpi2c clock specifier
...@@ -11,7 +10,7 @@ Required properties: ...@@ -11,7 +10,7 @@ Required properties:
Examples: Examples:
lpi2c7: lpi2c7@40a50000 { lpi2c7: lpi2c7@40a50000 {
compatible = "fsl,imx8dv-lpi2c"; compatible = "fsl,imx7ulp-lpi2c";
reg = <0x40A50000 0x10000>; reg = <0x40A50000 0x10000>;
interrupt-parent = <&intc>; interrupt-parent = <&intc>;
interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>; interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;
......
...@@ -2311,6 +2311,7 @@ F: drivers/clocksource/cadence_ttc_timer.c ...@@ -2311,6 +2311,7 @@ F: drivers/clocksource/cadence_ttc_timer.c
F: drivers/i2c/busses/i2c-cadence.c F: drivers/i2c/busses/i2c-cadence.c
F: drivers/mmc/host/sdhci-of-arasan.c F: drivers/mmc/host/sdhci-of-arasan.c
F: drivers/edac/synopsys_edac.c F: drivers/edac/synopsys_edac.c
F: drivers/i2c/busses/i2c-xiic.c
ARM64 PORT (AARCH64 ARCHITECTURE) ARM64 PORT (AARCH64 ARCHITECTURE)
M: Catalin Marinas <catalin.marinas@arm.com> M: Catalin Marinas <catalin.marinas@arm.com>
......
...@@ -140,6 +140,7 @@ ...@@ -140,6 +140,7 @@
#define SBREG_BAR 0x10 #define SBREG_BAR 0x10
#define SBREG_SMBCTRL 0xc6000c #define SBREG_SMBCTRL 0xc6000c
#define SBREG_SMBCTRL_DNV 0xcf000c
/* Host status bits for SMBPCISTS */ /* Host status bits for SMBPCISTS */
#define SMBPCISTS_INTS BIT(3) #define SMBPCISTS_INTS BIT(3)
...@@ -1399,7 +1400,11 @@ static void i801_add_tco(struct i801_priv *priv) ...@@ -1399,7 +1400,11 @@ static void i801_add_tco(struct i801_priv *priv)
spin_unlock(&p2sb_spinlock); spin_unlock(&p2sb_spinlock);
res = &tco_res[ICH_RES_MEM_OFF]; res = &tco_res[ICH_RES_MEM_OFF];
if (pci_dev->device == PCI_DEVICE_ID_INTEL_DNV_SMBUS)
res->start = (resource_size_t)base64_addr + SBREG_SMBCTRL_DNV;
else
res->start = (resource_size_t)base64_addr + SBREG_SMBCTRL; res->start = (resource_size_t)base64_addr + SBREG_SMBCTRL;
res->end = res->start + 3; res->end = res->start + 3;
res->flags = IORESOURCE_MEM; res->flags = IORESOURCE_MEM;
......
...@@ -538,7 +538,6 @@ static const struct i2c_algorithm lpi2c_imx_algo = { ...@@ -538,7 +538,6 @@ static const struct i2c_algorithm lpi2c_imx_algo = {
static const struct of_device_id lpi2c_imx_of_match[] = { static const struct of_device_id lpi2c_imx_of_match[] = {
{ .compatible = "fsl,imx7ulp-lpi2c" }, { .compatible = "fsl,imx7ulp-lpi2c" },
{ .compatible = "fsl,imx8dv-lpi2c" },
{ }, { },
}; };
MODULE_DEVICE_TABLE(of, lpi2c_imx_of_match); MODULE_DEVICE_TABLE(of, lpi2c_imx_of_match);
......
...@@ -401,11 +401,8 @@ static int uniphier_fi2c_master_xfer(struct i2c_adapter *adap, ...@@ -401,11 +401,8 @@ static int uniphier_fi2c_master_xfer(struct i2c_adapter *adap,
return ret; return ret;
for (msg = msgs; msg < emsg; msg++) { for (msg = msgs; msg < emsg; msg++) {
/* If next message is read, skip the stop condition */ /* Emit STOP if it is the last message or I2C_M_STOP is set. */
bool stop = !(msg + 1 < emsg && msg[1].flags & I2C_M_RD); bool stop = (msg + 1 == emsg) || (msg->flags & I2C_M_STOP);
/* but, force it if I2C_M_STOP is set */
if (msg->flags & I2C_M_STOP)
stop = true;
ret = uniphier_fi2c_master_xfer_one(adap, msg, stop); ret = uniphier_fi2c_master_xfer_one(adap, msg, stop);
if (ret) if (ret)
......
...@@ -248,11 +248,8 @@ static int uniphier_i2c_master_xfer(struct i2c_adapter *adap, ...@@ -248,11 +248,8 @@ static int uniphier_i2c_master_xfer(struct i2c_adapter *adap,
return ret; return ret;
for (msg = msgs; msg < emsg; msg++) { for (msg = msgs; msg < emsg; msg++) {
/* If next message is read, skip the stop condition */ /* Emit STOP if it is the last message or I2C_M_STOP is set. */
bool stop = !(msg + 1 < emsg && msg[1].flags & I2C_M_RD); bool stop = (msg + 1 == emsg) || (msg->flags & I2C_M_STOP);
/* but, force it if I2C_M_STOP is set */
if (msg->flags & I2C_M_STOP)
stop = true;
ret = uniphier_i2c_master_xfer_one(adap, msg, stop); ret = uniphier_i2c_master_xfer_one(adap, msg, stop);
if (ret) if (ret)
......
...@@ -532,6 +532,7 @@ static void xiic_start_recv(struct xiic_i2c *i2c) ...@@ -532,6 +532,7 @@ static void xiic_start_recv(struct xiic_i2c *i2c)
{ {
u8 rx_watermark; u8 rx_watermark;
struct i2c_msg *msg = i2c->rx_msg = i2c->tx_msg; struct i2c_msg *msg = i2c->rx_msg = i2c->tx_msg;
unsigned long flags;
/* Clear and enable Rx full interrupt. */ /* Clear and enable Rx full interrupt. */
xiic_irq_clr_en(i2c, XIIC_INTR_RX_FULL_MASK | XIIC_INTR_TX_ERROR_MASK); xiic_irq_clr_en(i2c, XIIC_INTR_RX_FULL_MASK | XIIC_INTR_TX_ERROR_MASK);
...@@ -547,6 +548,7 @@ static void xiic_start_recv(struct xiic_i2c *i2c) ...@@ -547,6 +548,7 @@ static void xiic_start_recv(struct xiic_i2c *i2c)
rx_watermark = IIC_RX_FIFO_DEPTH; rx_watermark = IIC_RX_FIFO_DEPTH;
xiic_setreg8(i2c, XIIC_RFD_REG_OFFSET, rx_watermark - 1); xiic_setreg8(i2c, XIIC_RFD_REG_OFFSET, rx_watermark - 1);
local_irq_save(flags);
if (!(msg->flags & I2C_M_NOSTART)) if (!(msg->flags & I2C_M_NOSTART))
/* write the address */ /* write the address */
xiic_setreg16(i2c, XIIC_DTR_REG_OFFSET, xiic_setreg16(i2c, XIIC_DTR_REG_OFFSET,
...@@ -556,6 +558,8 @@ static void xiic_start_recv(struct xiic_i2c *i2c) ...@@ -556,6 +558,8 @@ static void xiic_start_recv(struct xiic_i2c *i2c)
xiic_setreg16(i2c, XIIC_DTR_REG_OFFSET, xiic_setreg16(i2c, XIIC_DTR_REG_OFFSET,
msg->len | ((i2c->nmsgs == 1) ? XIIC_TX_DYN_STOP_MASK : 0)); msg->len | ((i2c->nmsgs == 1) ? XIIC_TX_DYN_STOP_MASK : 0));
local_irq_restore(flags);
if (i2c->nmsgs == 1) if (i2c->nmsgs == 1)
/* very last, enable bus not busy as well */ /* very last, enable bus not busy as well */
xiic_irq_clr_en(i2c, XIIC_INTR_BNB_MASK); xiic_irq_clr_en(i2c, XIIC_INTR_BNB_MASK);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment