Commit d935ad91 authored by Eric Auger's avatar Eric Auger Committed by Alex Williamson

vfio: fix noiommu vfio_iommu_group_get reference count

In vfio_iommu_group_get() we want to increase the reference
count of the iommu group.

In noiommu case, the group does not exist and is allocated.
iommu_group_add_device() increases the group ref count. However we
then call iommu_group_put() which decrements it.

This leads to a "refcount_t: underflow WARN_ON".

Only decrement the ref count in case of iommu_group_add_device
failure.
Signed-off-by: default avatarEric Auger <eric.auger@redhat.com>
Signed-off-by: default avatarAlex Williamson <alex.williamson@redhat.com>
parent f203f7f1
...@@ -138,9 +138,10 @@ struct iommu_group *vfio_iommu_group_get(struct device *dev) ...@@ -138,9 +138,10 @@ struct iommu_group *vfio_iommu_group_get(struct device *dev)
iommu_group_set_name(group, "vfio-noiommu"); iommu_group_set_name(group, "vfio-noiommu");
iommu_group_set_iommudata(group, &noiommu, NULL); iommu_group_set_iommudata(group, &noiommu, NULL);
ret = iommu_group_add_device(group, dev); ret = iommu_group_add_device(group, dev);
if (ret) {
iommu_group_put(group); iommu_group_put(group);
if (ret)
return NULL; return NULL;
}
/* /*
* Where to taint? At this point we've added an IOMMU group for a * Where to taint? At this point we've added an IOMMU group for a
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment