Commit da7613b8 authored by NeilBrown's avatar NeilBrown

md/raid5: improve removal of extra devices after reshape.

After a reshape which reduced the number of devices we need
to disconnect the extra devices.
The code for this doesn't currently handle 'replacement' devices.
It is very unlikely that such devices will be present, but it is
safest to handle them anyway.

So simplify the handling.  Just clear In_sync and leave it
to remove_and_add_spaces (which will be called soon) to do
the real works.
Signed-off-by: default avatarNeilBrown <neilb@suse.de>
parent 0c098220
...@@ -5755,11 +5755,11 @@ static void raid5_finish_reshape(struct mddev *mddev) ...@@ -5755,11 +5755,11 @@ static void raid5_finish_reshape(struct mddev *mddev)
d < conf->raid_disks - mddev->delta_disks; d < conf->raid_disks - mddev->delta_disks;
d++) { d++) {
struct md_rdev *rdev = conf->disks[d].rdev; struct md_rdev *rdev = conf->disks[d].rdev;
if (rdev && if (rdev)
raid5_remove_disk(mddev, rdev) == 0) { clear_bit(In_sync, &rdev->flags);
sysfs_unlink_rdev(mddev, rdev); rdev = conf->disks[d].replacement;
rdev->raid_disk = -1; if (rdev)
} clear_bit(In_sync, &rdev->flags);
} }
} }
mddev->layout = conf->algorithm; mddev->layout = conf->algorithm;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment