Commit dbf56ab1 authored by Kent Russell's avatar Kent Russell Committed by Oded Gabbay

drm/amdkfd: Remove usage of alloc(sizeof(struct...

See https://kernel.org/doc/html/latest/process/coding-style.html
under "14) Allocating Memory" for rationale behind removing the
x=alloc(sizeof(struct) style and using x=alloc(sizeof(*x) instead
Signed-off-by: default avatarKent Russell <kent.russell@amd.com>
Signed-off-by: default avatarFelix Kuehling <Felix.Kuehling@amd.com>
Reviewed-by: default avatarOded Gabbay <oded.gabbay@gmail.com>
Signed-off-by: default avatarOded Gabbay <oded.gabbay@gmail.com>
parent ab7c1648
...@@ -422,7 +422,7 @@ static int register_process_nocpsch(struct device_queue_manager *dqm, ...@@ -422,7 +422,7 @@ static int register_process_nocpsch(struct device_queue_manager *dqm,
BUG_ON(!dqm || !qpd); BUG_ON(!dqm || !qpd);
n = kzalloc(sizeof(struct device_process_node), GFP_KERNEL); n = kzalloc(sizeof(*n), GFP_KERNEL);
if (!n) if (!n)
return -ENOMEM; return -ENOMEM;
...@@ -1135,7 +1135,7 @@ struct device_queue_manager *device_queue_manager_init(struct kfd_dev *dev) ...@@ -1135,7 +1135,7 @@ struct device_queue_manager *device_queue_manager_init(struct kfd_dev *dev)
pr_debug("Loading device queue manager\n"); pr_debug("Loading device queue manager\n");
dqm = kzalloc(sizeof(struct device_queue_manager), GFP_KERNEL); dqm = kzalloc(sizeof(*dqm), GFP_KERNEL);
if (!dqm) if (!dqm)
return NULL; return NULL;
......
...@@ -283,7 +283,7 @@ struct kernel_queue *kernel_queue_init(struct kfd_dev *dev, ...@@ -283,7 +283,7 @@ struct kernel_queue *kernel_queue_init(struct kfd_dev *dev,
BUG_ON(!dev); BUG_ON(!dev);
kq = kzalloc(sizeof(struct kernel_queue), GFP_KERNEL); kq = kzalloc(sizeof(*kq), GFP_KERNEL);
if (!kq) if (!kq)
return NULL; return NULL;
......
...@@ -406,7 +406,7 @@ struct mqd_manager *mqd_manager_init_cik(enum KFD_MQD_TYPE type, ...@@ -406,7 +406,7 @@ struct mqd_manager *mqd_manager_init_cik(enum KFD_MQD_TYPE type,
BUG_ON(!dev); BUG_ON(!dev);
BUG_ON(type >= KFD_MQD_TYPE_MAX); BUG_ON(type >= KFD_MQD_TYPE_MAX);
mqd = kzalloc(sizeof(struct mqd_manager), GFP_KERNEL); mqd = kzalloc(sizeof(*mqd), GFP_KERNEL);
if (!mqd) if (!mqd)
return NULL; return NULL;
......
...@@ -239,7 +239,7 @@ struct mqd_manager *mqd_manager_init_vi(enum KFD_MQD_TYPE type, ...@@ -239,7 +239,7 @@ struct mqd_manager *mqd_manager_init_vi(enum KFD_MQD_TYPE type,
BUG_ON(!dev); BUG_ON(!dev);
BUG_ON(type >= KFD_MQD_TYPE_MAX); BUG_ON(type >= KFD_MQD_TYPE_MAX);
mqd = kzalloc(sizeof(struct mqd_manager), GFP_KERNEL); mqd = kzalloc(sizeof(*mqd), GFP_KERNEL);
if (!mqd) if (!mqd)
return NULL; return NULL;
......
...@@ -187,7 +187,7 @@ int pqm_create_queue(struct process_queue_manager *pqm, ...@@ -187,7 +187,7 @@ int pqm_create_queue(struct process_queue_manager *pqm,
dev->dqm->ops.register_process(dev->dqm, &pdd->qpd); dev->dqm->ops.register_process(dev->dqm, &pdd->qpd);
} }
pqn = kzalloc(sizeof(struct process_queue_node), GFP_KERNEL); pqn = kzalloc(sizeof(*pqn), GFP_KERNEL);
if (!pqn) { if (!pqn) {
retval = -ENOMEM; retval = -ENOMEM;
goto err_allocate_pqn; goto err_allocate_pqn;
......
...@@ -65,17 +65,17 @@ void print_queue(struct queue *q) ...@@ -65,17 +65,17 @@ void print_queue(struct queue *q)
int init_queue(struct queue **q, const struct queue_properties *properties) int init_queue(struct queue **q, const struct queue_properties *properties)
{ {
struct queue *tmp; struct queue *tmp_q;
BUG_ON(!q); BUG_ON(!q);
tmp = kzalloc(sizeof(struct queue), GFP_KERNEL); tmp_q = kzalloc(sizeof(*tmp_q), GFP_KERNEL);
if (!tmp) if (!tmp_q)
return -ENOMEM; return -ENOMEM;
memcpy(&tmp->properties, properties, sizeof(struct queue_properties)); memcpy(&tmp_q->properties, properties, sizeof(*properties));
*q = tmp; *q = tmp_q;
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment