Commit de55a7a5 authored by Stewart Robertson's avatar Stewart Robertson Committed by Greg Kroah-Hartman

Staging: comedi: fix comments over 80 issue in usbduxfast.c

This is a patch to the usbduxfast.c file that fixes comments
over 80 warnings found by the checkpatch.pl tool
Signed-off-by: default avatarStewart Robertson <stewart_r@aliencamel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent a88e29cf
...@@ -177,8 +177,8 @@ struct usbduxfastsub_s { ...@@ -177,8 +177,8 @@ struct usbduxfastsub_s {
int16_t *insnBuffer; /* input buffer for single insn */ int16_t *insnBuffer; /* input buffer for single insn */
int ifnum; /* interface number */ int ifnum; /* interface number */
struct usb_interface *interface; /* interface structure */ struct usb_interface *interface; /* interface structure */
struct comedi_device *comedidev; /* comedi device for the interrupt /* comedi device for the interrupt context */
context */ struct comedi_device *comedidev;
short int ai_cmd_running; /* asynchronous command is running */ short int ai_cmd_running; /* asynchronous command is running */
short int ai_continous; /* continous aquisition */ short int ai_continous; /* continous aquisition */
long int ai_sample_count; /* number of samples to acquire */ long int ai_sample_count; /* number of samples to acquire */
...@@ -271,7 +271,8 @@ static int usbduxfast_ai_stop(struct usbduxfastsub_s *udfs, int do_unlink) ...@@ -271,7 +271,8 @@ static int usbduxfast_ai_stop(struct usbduxfastsub_s *udfs, int do_unlink)
udfs->ai_cmd_running = 0; udfs->ai_cmd_running = 0;
if (do_unlink) if (do_unlink)
ret = usbduxfastsub_unlink_InURBs(udfs); /* stop aquistion */ /* stop aquistion */
ret = usbduxfastsub_unlink_InURBs(udfs);
return ret; return ret;
} }
...@@ -451,13 +452,15 @@ static int usbduxfastsub_start(struct usbduxfastsub_s *udfs) ...@@ -451,13 +452,15 @@ static int usbduxfastsub_start(struct usbduxfastsub_s *udfs)
/* 7f92 to zero */ /* 7f92 to zero */
local_transfer_buffer[0] = 0; local_transfer_buffer[0] = 0;
ret = usb_control_msg(udfs->usbdev, usb_sndctrlpipe(udfs->usbdev, 0), USBDUXFASTSUB_FIRMWARE, /* bRequest, "Firmware" */ /* bRequest, "Firmware" */
VENDOR_DIR_OUT, /* bmRequestType */ ret = usb_control_msg(udfs->usbdev, usb_sndctrlpipe(udfs->usbdev, 0), USBDUXFASTSUB_FIRMWARE,
USBDUXFASTSUB_CPUCS, /* Value */ VENDOR_DIR_OUT, /* bmRequestType */
0x0000, /* Index */ USBDUXFASTSUB_CPUCS, /* Value */
local_transfer_buffer, /* address of the transfer buffer */ 0x0000, /* Index */
1, /* Length */ /* address of the transfer buffer */
EZTIMEOUT); /* Timeout */ local_transfer_buffer,
1, /* Length */
EZTIMEOUT); /* Timeout */
if (ret < 0) { if (ret < 0) {
printk("comedi_: usbduxfast_: control msg failed (start)\n"); printk("comedi_: usbduxfast_: control msg failed (start)\n");
return ret; return ret;
...@@ -473,7 +476,8 @@ static int usbduxfastsub_stop(struct usbduxfastsub_s *udfs) ...@@ -473,7 +476,8 @@ static int usbduxfastsub_stop(struct usbduxfastsub_s *udfs)
/* 7f92 to one */ /* 7f92 to one */
local_transfer_buffer[0] = 1; local_transfer_buffer[0] = 1;
ret = usb_control_msg(udfs->usbdev, usb_sndctrlpipe(udfs->usbdev, 0), USBDUXFASTSUB_FIRMWARE, /* bRequest, "Firmware" */ /* bRequest, "Firmware" */
ret = usb_control_msg(udfs->usbdev, usb_sndctrlpipe(udfs->usbdev, 0), USBDUXFASTSUB_FIRMWARE,
VENDOR_DIR_OUT, /* bmRequestType */ VENDOR_DIR_OUT, /* bmRequestType */
USBDUXFASTSUB_CPUCS, /* Value */ USBDUXFASTSUB_CPUCS, /* Value */
0x0000, /* Index */ 0x0000, /* Index */
...@@ -499,13 +503,15 @@ static int usbduxfastsub_upload(struct usbduxfastsub_s *udfs, ...@@ -499,13 +503,15 @@ static int usbduxfastsub_upload(struct usbduxfastsub_s *udfs,
printk(KERN_DEBUG " to addr %d, first byte=%d.\n", printk(KERN_DEBUG " to addr %d, first byte=%d.\n",
startAddr, local_transfer_buffer[0]); startAddr, local_transfer_buffer[0]);
#endif #endif
ret = usb_control_msg(udfs->usbdev, usb_sndctrlpipe(udfs->usbdev, 0), USBDUXFASTSUB_FIRMWARE, /* brequest, firmware */ /* brequest, firmware */
VENDOR_DIR_OUT, /* bmRequestType */ ret = usb_control_msg(udfs->usbdev, usb_sndctrlpipe(udfs->usbdev, 0), USBDUXFASTSUB_FIRMWARE,
startAddr, /* value */ VENDOR_DIR_OUT, /* bmRequestType */
0x0000, /* index */ startAddr, /* value */
local_transfer_buffer, /* our local safe buffer */ 0x0000, /* index */
len, /* length */ /* our local safe buffer */
EZTIMEOUT); /* timeout */ local_transfer_buffer,
len, /* length */
EZTIMEOUT); /* timeout */
#ifdef CONFIG_COMEDI_DEBUG #ifdef CONFIG_COMEDI_DEBUG
printk(KERN_DEBUG "comedi_: usbduxfast: result=%d\n", ret); printk(KERN_DEBUG "comedi_: usbduxfast: result=%d\n", ret);
...@@ -1347,7 +1353,7 @@ static int usbduxfast_ai_insn_read(struct comedi_device *dev, ...@@ -1347,7 +1353,7 @@ static int usbduxfast_ai_insn_read(struct comedi_device *dev,
#define FIRMWARE_MAX_LEN 0x2000 #define FIRMWARE_MAX_LEN 0x2000
static int firmwareUpload(struct usbduxfastsub_s *usbduxfastsub, static int firmwareUpload(struct usbduxfastsub_s *usbduxfastsub,
const u8 * firmwareBinary, int sizeFirmware) const u8 *firmwareBinary, int sizeFirmware)
{ {
int ret; int ret;
uint8_t *fwBuf; uint8_t *fwBuf;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment