Commit de6cdcb5 authored by Muhammad Falak R Wani's avatar Muhammad Falak R Wani Committed by Linus Torvalds

drivers/memstick/core/mspro_block: use kmemdup

Use kmemdup when some other buffer is immediately copied into allocated
region.  It replaces call to allocation followed by memcpy, by a single
call to kmemdup.

[akpm@linux-foundation.org: remove unneeded cast to void*]
Link: http://lkml.kernel.org/r/1463665743-16269-1-git-send-email-falakreyaz@gmail.comSigned-off-by: default avatarMuhammad Falak R Wani <falakreyaz@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent a831979f
...@@ -1033,12 +1033,11 @@ static int mspro_block_read_attributes(struct memstick_dev *card) ...@@ -1033,12 +1033,11 @@ static int mspro_block_read_attributes(struct memstick_dev *card)
} }
msb->attr_group.name = "media_attributes"; msb->attr_group.name = "media_attributes";
buffer = kmalloc(attr_len, GFP_KERNEL); buffer = kmemdup(attr, attr_len, GFP_KERNEL);
if (!buffer) { if (!buffer) {
rc = -ENOMEM; rc = -ENOMEM;
goto out_free_attr; goto out_free_attr;
} }
memcpy(buffer, (char *)attr, attr_len);
for (cnt = 0; cnt < attr_count; ++cnt) { for (cnt = 0; cnt < attr_count; ++cnt) {
s_attr = kzalloc(sizeof(struct mspro_sys_attr), GFP_KERNEL); s_attr = kzalloc(sizeof(struct mspro_sys_attr), GFP_KERNEL);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment