Commit de77d4da authored by Paul E. McKenney's avatar Paul E. McKenney

scftorture: Check unexpected "switch" statement value

This commit adds a "default" case to the switch statement in
scftorture_invoke_one() which contains a WARN_ON_ONCE() and an assignment
to ->scfc_out to suppress knock-on warnings.  These knock-on warnings
could otherwise cause the user to think that there was a memory-ordering
problem in smp_call_function() instead of a bug in scftorture.c itself.
Signed-off-by: default avatarPaul E. McKenney <paulmck@kernel.org>
parent 9a52a574
...@@ -357,6 +357,10 @@ static void scftorture_invoke_one(struct scf_statistics *scfp, struct torture_ra ...@@ -357,6 +357,10 @@ static void scftorture_invoke_one(struct scf_statistics *scfp, struct torture_ra
} }
smp_call_function(scf_handler, scfcp, scfsp->scfs_wait); smp_call_function(scf_handler, scfcp, scfsp->scfs_wait);
break; break;
default:
WARN_ON_ONCE(1);
if (scfcp)
scfcp->scfc_out = true;
} }
if (scfcp && scfsp->scfs_wait) { if (scfcp && scfsp->scfs_wait) {
if (WARN_ON_ONCE(!scfcp->scfc_out)) if (WARN_ON_ONCE(!scfcp->scfc_out))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment