Commit de8d5ab2 authored by Gal Pressman's avatar Gal Pressman Committed by David S. Miller

net: Make RX-FCS and HW GRO mutually exclusive

Same as LRO, hardware GRO cannot be enabled with RX-FCS.
When both are requested, hardware GRO will be dropped.
Suggested-by: default avatarDavid Miller <davem@davemloft.net>
Signed-off-by: default avatarGal Pressman <galp@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 678f4bda
...@@ -7549,10 +7549,17 @@ static netdev_features_t netdev_fix_features(struct net_device *dev, ...@@ -7549,10 +7549,17 @@ static netdev_features_t netdev_fix_features(struct net_device *dev,
} }
} }
/* LRO feature cannot be combined with RX-FCS */ /* LRO/HW-GRO features cannot be combined with RX-FCS */
if ((features & NETIF_F_LRO) && (features & NETIF_F_RXFCS)) { if (features & NETIF_F_RXFCS) {
netdev_dbg(dev, "Dropping LRO feature since RX-FCS is requested.\n"); if (features & NETIF_F_LRO) {
features &= ~NETIF_F_LRO; netdev_dbg(dev, "Dropping LRO feature since RX-FCS is requested.\n");
features &= ~NETIF_F_LRO;
}
if (features & NETIF_F_GRO_HW) {
netdev_dbg(dev, "Dropping HW-GRO feature since RX-FCS is requested.\n");
features &= ~NETIF_F_GRO_HW;
}
} }
return features; return features;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment