Commit df191632 authored by Florian Fainelli's avatar Florian Fainelli Committed by David S. Miller

net: dsa: bcm_sf2: Fix number of CFP entries for BCM7278

BCM7278 has only 128 entries while BCM7445 has the full 256 entries set,
fix that.

Fixes: 7318166c ("net: dsa: bcm_sf2: Add support for ethtool::rxnfc")
Signed-off-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Reviewed-by: default avatarVivien Didelot <vivien.didelot@savoirfairelinux.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 351050ec
...@@ -1048,6 +1048,7 @@ struct bcm_sf2_of_data { ...@@ -1048,6 +1048,7 @@ struct bcm_sf2_of_data {
u32 type; u32 type;
const u16 *reg_offsets; const u16 *reg_offsets;
unsigned int core_reg_align; unsigned int core_reg_align;
unsigned int num_cfp_rules;
}; };
/* Register offsets for the SWITCH_REG_* block */ /* Register offsets for the SWITCH_REG_* block */
...@@ -1071,6 +1072,7 @@ static const struct bcm_sf2_of_data bcm_sf2_7445_data = { ...@@ -1071,6 +1072,7 @@ static const struct bcm_sf2_of_data bcm_sf2_7445_data = {
.type = BCM7445_DEVICE_ID, .type = BCM7445_DEVICE_ID,
.core_reg_align = 0, .core_reg_align = 0,
.reg_offsets = bcm_sf2_7445_reg_offsets, .reg_offsets = bcm_sf2_7445_reg_offsets,
.num_cfp_rules = 256,
}; };
static const u16 bcm_sf2_7278_reg_offsets[] = { static const u16 bcm_sf2_7278_reg_offsets[] = {
...@@ -1093,6 +1095,7 @@ static const struct bcm_sf2_of_data bcm_sf2_7278_data = { ...@@ -1093,6 +1095,7 @@ static const struct bcm_sf2_of_data bcm_sf2_7278_data = {
.type = BCM7278_DEVICE_ID, .type = BCM7278_DEVICE_ID,
.core_reg_align = 1, .core_reg_align = 1,
.reg_offsets = bcm_sf2_7278_reg_offsets, .reg_offsets = bcm_sf2_7278_reg_offsets,
.num_cfp_rules = 128,
}; };
static const struct of_device_id bcm_sf2_of_match[] = { static const struct of_device_id bcm_sf2_of_match[] = {
...@@ -1149,6 +1152,7 @@ static int bcm_sf2_sw_probe(struct platform_device *pdev) ...@@ -1149,6 +1152,7 @@ static int bcm_sf2_sw_probe(struct platform_device *pdev)
priv->type = data->type; priv->type = data->type;
priv->reg_offsets = data->reg_offsets; priv->reg_offsets = data->reg_offsets;
priv->core_reg_align = data->core_reg_align; priv->core_reg_align = data->core_reg_align;
priv->num_cfp_rules = data->num_cfp_rules;
/* Auto-detection using standard registers will not work, so /* Auto-detection using standard registers will not work, so
* provide an indication of what kind of device we are for * provide an indication of what kind of device we are for
......
...@@ -72,6 +72,7 @@ struct bcm_sf2_priv { ...@@ -72,6 +72,7 @@ struct bcm_sf2_priv {
u32 type; u32 type;
const u16 *reg_offsets; const u16 *reg_offsets;
unsigned int core_reg_align; unsigned int core_reg_align;
unsigned int num_cfp_rules;
/* spinlock protecting access to the indirect registers */ /* spinlock protecting access to the indirect registers */
spinlock_t indir_lock; spinlock_t indir_lock;
......
...@@ -98,7 +98,7 @@ static inline void bcm_sf2_cfp_rule_addr_set(struct bcm_sf2_priv *priv, ...@@ -98,7 +98,7 @@ static inline void bcm_sf2_cfp_rule_addr_set(struct bcm_sf2_priv *priv,
{ {
u32 reg; u32 reg;
WARN_ON(addr >= CFP_NUM_RULES); WARN_ON(addr >= priv->num_cfp_rules);
reg = core_readl(priv, CORE_CFP_ACC); reg = core_readl(priv, CORE_CFP_ACC);
reg &= ~(XCESS_ADDR_MASK << XCESS_ADDR_SHIFT); reg &= ~(XCESS_ADDR_MASK << XCESS_ADDR_SHIFT);
...@@ -109,7 +109,7 @@ static inline void bcm_sf2_cfp_rule_addr_set(struct bcm_sf2_priv *priv, ...@@ -109,7 +109,7 @@ static inline void bcm_sf2_cfp_rule_addr_set(struct bcm_sf2_priv *priv,
static inline unsigned int bcm_sf2_cfp_rule_size(struct bcm_sf2_priv *priv) static inline unsigned int bcm_sf2_cfp_rule_size(struct bcm_sf2_priv *priv)
{ {
/* Entry #0 is reserved */ /* Entry #0 is reserved */
return CFP_NUM_RULES - 1; return priv->num_cfp_rules - 1;
} }
static int bcm_sf2_cfp_rule_set(struct dsa_switch *ds, int port, static int bcm_sf2_cfp_rule_set(struct dsa_switch *ds, int port,
...@@ -523,7 +523,7 @@ static int bcm_sf2_cfp_rule_get_all(struct bcm_sf2_priv *priv, ...@@ -523,7 +523,7 @@ static int bcm_sf2_cfp_rule_get_all(struct bcm_sf2_priv *priv,
if (!(reg & OP_STR_DONE)) if (!(reg & OP_STR_DONE))
break; break;
} while (index < CFP_NUM_RULES); } while (index < priv->num_cfp_rules);
/* Put the TCAM size here */ /* Put the TCAM size here */
nfc->data = bcm_sf2_cfp_rule_size(priv); nfc->data = bcm_sf2_cfp_rule_size(priv);
...@@ -544,7 +544,7 @@ int bcm_sf2_get_rxnfc(struct dsa_switch *ds, int port, ...@@ -544,7 +544,7 @@ int bcm_sf2_get_rxnfc(struct dsa_switch *ds, int port,
case ETHTOOL_GRXCLSRLCNT: case ETHTOOL_GRXCLSRLCNT:
/* Subtract the default, unusable rule */ /* Subtract the default, unusable rule */
nfc->rule_cnt = bitmap_weight(priv->cfp.used, nfc->rule_cnt = bitmap_weight(priv->cfp.used,
CFP_NUM_RULES) - 1; priv->num_cfp_rules) - 1;
/* We support specifying rule locations */ /* We support specifying rule locations */
nfc->data |= RX_CLS_LOC_SPECIAL; nfc->data |= RX_CLS_LOC_SPECIAL;
break; break;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment