Commit e1efdea5 authored by James Bottomley's avatar James Bottomley Committed by Linus Torvalds

[PATCH] Add Domain Validation to 53c700 driver

This simply throws out the 53c700 driver's optimistic setting of the
best possible transport parameters and replaces it with DV
determination.  It also adds a missing report_bus_reset() callback and
finally does a delayed DV on device errors.
parent 4352438e
...@@ -1522,6 +1522,8 @@ NCR_700_intr(int irq, void *dev_id, struct pt_regs *regs) ...@@ -1522,6 +1522,8 @@ NCR_700_intr(int irq, void *dev_id, struct pt_regs *regs)
printk(KERN_ERR "scsi%d: Bus Reset detected, executing command %p, slot %p, dsp %08x[%04x]\n", printk(KERN_ERR "scsi%d: Bus Reset detected, executing command %p, slot %p, dsp %08x[%04x]\n",
host->host_no, SCp, SCp == NULL ? NULL : SCp->host_scribble, dsp, dsp - hostdata->pScript); host->host_no, SCp, SCp == NULL ? NULL : SCp->host_scribble, dsp, dsp - hostdata->pScript);
scsi_report_bus_reset(host, 0);
/* clear all the negotiated parameters */ /* clear all the negotiated parameters */
__shost_for_each_device(SDp, host) __shost_for_each_device(SDp, host)
SDp->hostdata = 0; SDp->hostdata = 0;
...@@ -1967,6 +1969,9 @@ NCR_700_bus_reset(Scsi_Cmnd * SCp) ...@@ -1967,6 +1969,9 @@ NCR_700_bus_reset(Scsi_Cmnd * SCp)
wait_for_completion(&complete); wait_for_completion(&complete);
spin_lock_irq(SCp->device->host->host_lock); spin_lock_irq(SCp->device->host->host_lock);
hostdata->eh_complete = NULL; hostdata->eh_complete = NULL;
/* Revalidate the transport parameters of the failing device */
if(hostdata->fast)
spi_schedule_dv_device(SCp->device);
return SUCCESS; return SUCCESS;
} }
...@@ -2051,9 +2056,11 @@ NCR_700_slave_configure(Scsi_Device *SDp) ...@@ -2051,9 +2056,11 @@ NCR_700_slave_configure(Scsi_Device *SDp)
scsi_adjust_queue_depth(SDp, 0, SDp->host->cmd_per_lun); scsi_adjust_queue_depth(SDp, 0, SDp->host->cmd_per_lun);
} }
if(hostdata->fast) { if(hostdata->fast) {
NCR_700_set_period(SDp, hostdata->min_period); /* Find the correct offset and period via domain validation */
NCR_700_set_offset(SDp, hostdata->chip710 spi_dv_device(SDp);
? NCR_710_MAX_OFFSET : NCR_700_MAX_OFFSET); } else {
spi_offset(SDp) = 0;
spi_period(SDp) = 0;
} }
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment